Open
Bug 449728
Opened 16 years ago
Updated 5 years ago
Write front-end code to use backend Drag & Drop tabs between browser windows functionality.
Categories
(SeaMonkey :: Tabbed Browser, enhancement)
SeaMonkey
Tabbed Browser
Tracking
(seamonkey2.1 wontfix)
NEW
Tracking | Status | |
---|---|---|
seamonkey2.1 | --- | wontfix |
People
(Reporter: bzbarsky, Unassigned)
References
(Blocks 3 open bugs)
Details
(Keywords: helpwanted)
Attachments
(1 file)
9.67 KB,
patch
|
Details | Diff | Splinter Review |
Sadly, I ended up hijacking a seamonkey bug for the core work... The seamonkey UI making use of that core work still needs to be written.
Updated•16 years ago
|
OS: Mac OS X → All
Hardware: PC → All
Version: unspecified → Trunk
![]() |
||
Updated•16 years ago
|
Flags: wanted-seamonkey2?
Summary: Write front-end code to make use of the backend introduced in bug 113934 → Write front-end code to use backend Drag & Drop tabs between browser windows functionality.
![]() |
||
Updated•16 years ago
|
Keywords: student-project
![]() |
||
Comment 3•15 years ago
|
||
Enhancement, so not wanting it in 2.0 any more after the feature freeze. We really would love to see this in 2.1, though!
Severity: normal → enhancement
Flags: wanted-seamonkey2.1+
Flags: wanted-seamonkey2.0?
Flags: wanted-seamonkey2.0-
Comment 4•15 years ago
|
||
Jeffrey Lee, a student, is going to give this a shot. Can any of you provide him some clues to get started?
Assignee: nobody → jjlee16
Status: NEW → ASSIGNED
![]() |
Reporter | |
Comment 5•15 years ago
|
||
The patches in bug 113934 include the Firefox front-end code for this. And I can answer any specific questions about the backend that need answering.
Comment 6•15 years ago
|
||
I've been told i should start by learning how to install seamonkey. Where should i look or begin to start after that?
![]() |
Reporter | |
Comment 7•15 years ago
|
||
Probably in suite/browser/tabbrowser.xml in the comm-central tree.
![]() |
||
Comment 8•15 years ago
|
||
Jeffrey, any news on this? If you still need help on getting started, please contact us in the developer group/list or on IRC as stated on http://www.seamonkey-project.org/community
![]() |
||
Updated•15 years ago
|
status-seamonkey2.1:
--- → wanted
Flags: wanted-seamonkey2.1+
Comment 10•14 years ago
|
||
I've been looking into this, have a patch locally, but currently it doesn't make a difference; dragging a tab to the content area just loads it there. If I can get it to work I'll assign this bug to me, otherwise I'll post what I have and let someone else give it a try. In any case I'm not an expert in the field (tabbrowser), so don't expect me to answer "why like this and not like that" type of questions, I just tried to port http://hg.mozilla.org/mozilla-central/diff/48191fdcf8a7/browser/base/content/tabbrowser.xml despite all the differences of our implementation.
Keywords: student-project
Comment 11•14 years ago
|
||
OK, so this is actually a *lot* more complicated. Front-end-wise bug 113934 was merely the start. Many more changes to tabbrowser.xml and other files followed. Just to give you an impression (the list may be incomplete!): http://hg.mozilla.org/mozilla-central/rev/f682b584b24b http://hg.mozilla.org/mozilla-central/rev/1e91efd774f4 http://hg.mozilla.org/mozilla-central/rev/260df679b20d http://hg.mozilla.org/mozilla-central/rev/b4bf19fdef47 http://hg.mozilla.org/mozilla-central/rev/afc23b21a39c http://hg.mozilla.org/mozilla-central/rev/77a7aa432a4e http://hg.mozilla.org/mozilla-central/rev/81d198ae47a5 http://hg.mozilla.org/mozilla-central/rev/011726ff11de http://hg.mozilla.org/mozilla-central/rev/e1b547419223 If you look closer, changes were implemented, adapted, removed, replaced, back and forth (and many typos introduced). The changes to browser.js/xul (contentAreaDNDObserver, ondragleave/enter) are just one example. You have to consolidate all those changesets if you don't want to repeat those mistakes. On top of that, Firefox is now using a more general drag&drop handling approach, so the current Firefox trunk code is very different from the bug 113934 state. On top of *that*, SeaMonkey's tabbrowser.xml code is quite different when it comes to the implementation details, and a more strict review is applied to proposed patches. I expect this to take several months unless someone like Neil does it. IOW: I won't do this, sorry. I'll attach the tabbrowser.xml changes I implemented (which are useless without at least a matching d&d hook) just so that I didn't completely waste my time. Maybe it helps someone else. Please note that it's completely untested, though. Starting at zero might turn out to be the better idea.
Updated•14 years ago
|
Updated•13 years ago
|
Keywords: helpwanted
You need to log in
before you can comment on or make changes to this bug.
Description
•