449736 - [Bookmarks Toolbar]Chevron is not displayed when window width was narrowed.

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.2pre) Gecko/2008080705 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.2pre) Gecko/2008080705 Firefox/3.0.1

After drop-indicator was displayed, When I narrow window width than the drop-indicator indication point, chevron is not displayed.


Reproducible: Always

Steps to Reproduce:
1.Add enough a lot of bookmarks on the bookmarks toolbar inorder to display chevron.
2.Drag a bookmark on the bookmarks toolbar, and display drop-indicator at far right.
3.Shrink window
Actual Results:  
Chevron disappeared.

Expected Results:  
Chevron should be displayed.

After chevron disappeared.
1.Drag a bookmark on the bookmarks toolbar, and display drop-indicator at far left.

Then, Chevron appeared again.

Comment 1

[Alice0775 White]

I think that margin style sholuld be reset after dragging stopping/interrupting.

chrome\browser\content\browser\places\toolbar.xml

        notify: function TBV_DO_notify(timer) {
          // Timer to turn off indicator bar.
          if (timer == this._ibTimer) {
            ib = this._self._dropIndicatorBar.removeAttribute('dragging');
+           var ib = this._self._dropIndicatorBar;
+           var ind = ib.firstChild;
+           ind.style.marginLeft  = '0px';
+           ind.style.marginRight = '0px';
            this._ibTimer = null;
          }




        onDragOver: function TBV_DO_onDragOver(event, flavor, session) {
          PlacesControllerDragHelper.currentDropTarget = event.target;
          var dropPoint = this._getDropPoint(event);

          var ib = this._self._dropIndicatorBar;
          if (this._ibTimer) {
            this._ibTimer.cancel();
            this._ibTimer = null;
          }

          if (dropPoint.folderNode ||
              event.originalTarget == this._self._chevron) {
            // Dropping over a menubutton or chevron button
            // set styles and timer to open relative menupopup
            var overNode = dropPoint.folderNode || this._self._chevron;
            if (this._overFolder.node != overNode) {
              this._clearOverFolder();
              this._overFolder.node = overNode;
              this._overFolder.openTimer = this._setTimer(this._overFolder.hoverTime);
            }
            if (!this._overFolder.node.hasAttribute("dragover"))
              this._overFolder.node.setAttribute("dragover", "true");

            ib.removeAttribute("dragging");
+           var ind = ib.firstChild;
+           ind.style.marginLeft  = '0px';
+           ind.style.marginRight = '0px';
          }
          else {
            // Dragging over a normal toolbarbutton,

Comment 2

[Shawn Wilsher :sdwilsh]

Bulk closing all UNCONFIRMED bugs dealing with places that haven't had any bug activity in over 120 days, have no votes, and are not enhancement requests.

If you are still experiencing this issue in Firefox 3.0 or later, please re-open the bug with steps to reproduce (if they were not part of the original comment).

Comment 3

[Alice0775 White]

Attachment: evidence movie (1.2MByte)

This bug is not fixed yet.
There are problem in latest trunk and branch nightly.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20090718 Minefield/3.6a1pre ID:20090718050152

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.1pre) Gecko/20090718 Firefox/3.5.1pre ID:20090718041856

Comment 4

[Marco Bonardo [:mak]]

confirmed, bug 382466 should fix this though.
thank you.

Comment 5

[Marco Bonardo [:mak]]

this looks like still somehow valid, at least on Linux, if i drag&drop to a certain position in the toolbar, and then i shrink the window, the chevron gets blocked to such position.

this does not happen on Windows.

Comment 6

[Marco Bonardo [:mak]]

hmpf, i ended up testing 3.0.13 :\ resolving again, and retyring to fix my Linux build end

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv