gfxFont.cpp failed to compile with Sun Studio 12 since Aug 5th. The checkin is Bug 437356. Set up unified font entry object. r+sr=stuart The error is "../../../../gfx/thebes/src/gfxFont.cpp", line 1111: Error: Ambiguous "?:" expression, second operand of type "int" and third operand of type "nsRefPtr<gfxFont>" can be converted to one another. 1 Error(s) detected.
Created attachment 332917 [details] [diff] [review] patch
I'd prefer something like nsRefPtr<gfxFont> font = FindFontForChar(ch, prevCh, nextCh, (aRanges.Length() == 0) ? (gfxFont*) nsnull : (gfxFont*) (aRanges[aRanges.Length() - 1].font)); This avoids unneeded refcounting. If that works for the Solaris build, please submit another review.
Created attachment 333366 [details] [diff] [review] patch v2
Comment on attachment 333366 [details] [diff] [review] patch v2 Looks good
Attachment #333366 - Flags: review?(jdaggett) → review+
Attachment #333366 - Flags: superreview?(pavlov) → superreview+
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.