Closed Bug 449780 Opened 11 years ago Closed 11 years ago

[FIX]Frameloader swap doesn't play nice with bfcache

Categories

(Core :: Document Navigation, defect, P1)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

(Keywords: addon-compat, verified1.9.1)

Attachments

(1 file)

Swapping frameloaders blows away layout on the two current pages, but the bfcache layouts remain, with stale parent viewmanager/widget/etc pointers.  We should be blowing those away too.

This we certainly need for 1.9.1 if we're going to do the drag/drop thing...
Flags: blocking1.9.1?
Depends on: 396519
Flags: blocking1.9.1? → blocking1.9.1+
Priority: -- → P1
This is one of the known late-compat exceptions we're taking in Beta 3. Blizz, Sheppy, Fligtar: FYI. The compatibility hit here is near-negligible, according to bz, but full disclosure! :)
Keywords: late-compat
Rey + Paul - can you make sure this ends up on the 3.1 page for add-ons developers?
Attached patch FixSplinter Review
It sucks that we have to walk the whole session history, but oh, well.
Attachment #356083 - Flags: superreview?(jst)
Attachment #356083 - Flags: review?(jst)
No longer depends on: 396519
Summary: Frameloader swap doesn't play nice with bfcache → [FIX]Frameloader swap doesn't play nice with bfcache
Attachment #356083 - Flags: superreview?(jst)
Attachment #356083 - Flags: superreview+
Attachment #356083 - Flags: review?(jst)
Attachment #356083 - Flags: review+
Comment on attachment 356083 [details] [diff] [review]
Fix

Looks good!
Pushed http://hg.mozilla.org/releases/mozilla-1.9.1/rev/049bd5ae4aad
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Seeing as there hasn't been any discussions about this bug for 3 months and it's been in mochitest, I'm assuming there aren't any residual issues. I'm moving this to verified as a result. If anyone has any qualms, feel free to bring them up.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.