449833 - Need a platform color for chrome background on Mac OS X

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: fix v0.1

In bug 449832 I need the tabs' color to be safe from color-correction. As far as I know, there are only two things that aren't color-corrected when color management is enabled:
 - Things that are rendered with the native theme (-moz-appearance) and
 - platform colors.

In the case of bug 449832, -moz-appearance doesn't help (I need to be able to use border-radius on the background).

So in this patch I'm adding the colors -moz-mac-chrome-active and -moz-mac-chrome-inactive (for active and inactive windows).

The patch also contains some refactoring. I wanted to avoid repeatedly hardcoding the same colors, so I put them into a new file (nsNativeThemeColors.h) which is reused in nsLookAndFeel.mm, nsCocoaWindow.h and nsNativeThemeCocoa.mm.

The names of the file and of the functions in it are probably not the best; I'm open to suggestions.

The patch is on top of that for bug 439354.

Comment 1

[Josh Aas]

Comment on attachment 332994 [details] [diff] [review]
fix v0.1

+static int GetIntColor(ColorName name, BOOL isMain)
...
+static float GetFloatColor(ColorName name, BOOL isMain)
...
+static NSColor* GetNSColor(ColorName name, BOOL isMain)

Would be nice if these had more descriptive names. Fix that and r+.

Comment 2

[Markus Stange [:mstange]]

Attachment: better function names

Comment 3

[Stefan [:stefanh]]

http://hg.mozilla.org/mozilla-central/index.cgi/rev/2b246e03252b

Comment 4

[Stefan [:stefanh]]

This was backed out along with the backout of bug 439354 (perf hit)

Comment 5

[Markus Stange [:mstange]]

http://hg.mozilla.org/mozilla-central/rev/0561cb13ec86