449898 - [silme] diff.py L10nPackageDiff: extend getObjects(), getPackages(), implement getType()

Status: VERIFIED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Adrian Kalla [:adriank]]

Here is a small patch which implements a few ideas that I had today:

First of all, it makes possible to have tuples as input for this methods. So you will be able to search e.g. for ('added', 'removed', 'modified') without the need of going 3 times through the object list and it should make it easier to sort the object later. 

Regarding getType(): you may want to know if your object is e.g. of the type 'added' or 'removed'

Comment 1

[Adrian Kalla [:adriank]]

Attachment: the patch

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 333034 [details] [diff] [review]
the patch

>+  def getType(self, id):
>+    if id in self.objects:
>+        return self.objects[id]['type']
>+    return False
>+

You either want to have it scan for objects and packages and allow to narrow search to objects/packages by argument, or split it into getPackageType, getObjectType.

beside of that the patch looks good. Thanks Adrian!
Fix that and I'll check it in.

Comment 3

[Adrian Kalla [:adriank]]

Attachment: patch with addressed comments from Gandalf. Done by splitting the method

patch with addressed comments from Gandalf. Done by splitting the method

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 333162 [details] [diff] [review]
patch with addressed comments from Gandalf. Done by splitting the method

looks good! good job adrian.

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Sending        lib/mozilla/l10n/diff.py
Transmitting file data .
Committed revision 131.