450009 - Mochitest failures not making build fail

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Dave Townsend [:mossop]]

For some reason some of the tests added in bug 424813 are failing intermittently. They are also not turning the box orange on the tinderbox. Apparently the test failure is getting logged but the test process is still returning a success.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Looking at the buildbot log, there's 
...
*** 20543 ERROR FAIL | fx module: animate option (queue === false) | Animations finished in the correct order expected: [ 1, 2, 3 ] result: [ 2, 1, 3 ]"
...
program finished with exit code 0

Comment 2

[(not currently active) Ted Mielczarek]

That's not printing a proper error output. Is that code using SimpleTest.ok()?
http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/SimpleTest.js#36

Comment 3

[Heather Arthur [:harth]]

this is where it is using SimpleTest.ok:

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/ajax/jquery/test/data/testrunner.js#148

It's in a conditional, but isn't SimpleTest.ok() what writes to the log?

http://mxr.mozilla.org/mozilla-central/source/dom/tests/mochitest/ajax/lib/SimpleTest.js#36

I'll separate this failure out and get a new patch out.

Comment 4

[(not currently active) Ted Mielczarek]

Ah, I had no idea there were other copies of SimpleTest in the tree!

Could you apply this SimpleTest.js patch to the other copies:
http://hg.mozilla.org/mozilla-central/index.cgi/raw-diff/b2d1c3093a84/testing/mochitest/tests/SimpleTest/SimpleTest.js

(Apparently I missed this in bug 443090)

Comment 5

[Heather Arthur [:harth]]

Attachment: patch for updating SimpleTest.js's

good catch. This patch syncs 
dom/tests/mochitest/ajax/lib/SimpleTest.js and
dom/tests/mochitest/ajax/mochikit/tests/SimpleTest/SimpleTest.js 
with:
testing/mochitest/tests/SimpleTest/SimpleTest.js 

and comments out the failing test in the jquery suite.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 333317 [details] [diff] [review]
patch for updating SimpleTest.js's

r=me, but please file a new bug (if there isn't already) about the failing test, and mention the bug number in the comment.

Comment 7

[Heather Arthur [:harth]]

following up in bug 450190

Comment 8

[cmtalbert]

checked in:
comparing with ssh://hg.mozilla.org/mozilla-central/
searching for changes
changeset:   16683:1b00cb58ed69
tag:         tip
user:        Clint Talbert <[e-mail]>
date:        Thu Aug 14 10:26:45 2008 -0700
summary:     Bug 450009, patch by Harthur, r=ted"

h-158:~/code/mozcentral/src clint$ hg push
Enter passphrase for key '/Users/clint/.ssh/id_dsa': 
pushing to ssh://hg.mozilla.org/mozilla-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 3 changes to 3 files