450143 - don't populate Build ID# if test is non-browser product, eg Thunderbird

Status: RESOLVED WONTFIX

(Webtools Graveyard :: Litmus, defect, P1)

Description

[Wayne Mery (:wsmwk)]

please don't populate Build ID# if test is non-browser product, eg Thunderbird

situation is similar to bugzilla's guided entry form....we have and will continue to have testers to aren't too experienced.  So if the  Build ID#  is filled in with the browser's UA, then the tester doesn't notice they need to change it, or thinks they don't have to replace it.  

Their tests get tagged with the wrong build id - then reporting, vetting, etc becomes is a mess :(

Comment 1

[Tony Chung [:tchung]]

This is messing up all products non firefox, and can cause reporting headaches.

Comment 2

[Fred Wenzel [:wenzel]]

What page does this occur on? At first sight, I was not able to find where the build ID is pre-populated in the first place.

Comment 3

[Wayne Mery (:wsmwk)]

1. https://litmus.mozilla.org/
2. pick thunderbird catchall tests, i.e. https://litmus.mozilla.org/run_tests.cgi?test_run_id=30

expected results: build id would be empty

actual results: build id# has been populated with firefox's buildid ... despite it's thunderbird testrun

Comment 4

[Fred Wenzel [:wenzel]]

Thanks, I can confirm this and will fix it.

Comment 5

[Fred Wenzel [:wenzel]]

Attachment: Reduce build ID sniffing

This patch only sniffs the build ID if
a) test run is browser-related (i.e., Firefox or SeaMonkey) and
b) the test run's browser type matches the one currently used.

Coop, if you feel somebody else should review these patches, please let me know.

Comment 6

[Chris Cooper [:coop] (he/him)]

Comment on attachment 365637 [details] [diff] [review]
Reduce build ID sniffing

I dislike having the pids in there. Could we not change Litmus::DB::TestRun->getTestRunWithRefs to return the product name, and then compare that directly?

if (product.toLowerCase() == test_run['product_id']['product_name'].toLowerCase()) {

Comment 7

[Wayne Mery (:wsmwk)]

Frédéric, possible to drive in revised patch?

Comment 8

[Fred Wenzel [:wenzel]]

Sorry, I haven't got to it lately. I'm still planning on making a new patch, but if you want to pick up my patch and change it according to coop's comments in comment 6, please go right ahead.

Comment 9

[Fred Wenzel [:wenzel]]

(In reply to comment #6)
> I dislike having the pids in there. Could we not change
> Litmus::DB::TestRun->getTestRunWithRefs to return the product name, and then
> compare that directly?

Coop, I don't know why the product model (referenced by the testrun model) does not already contain the name? I think I need Perl advice :)

Comment 10

[Fred Wenzel [:wenzel]]

reducing severity for now. If anyone knowing more about Perl than I do wants to help out on comment 9, thanks in advance.

Comment 11

[Chris Cooper [:coop] (he/him)]

Litmus is being decommissioned in bug 802674. 

Visit https://moztrap.mozilla.org for your testing needs.