Closed
Bug 450147
Opened 16 years ago
Closed 16 years ago
Some locales need to add "of" to the yearly-period-absolute-controls in Edit Recurrence window
Categories
(Calendar :: General, defect)
Calendar
General
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: hubert+bmo, Assigned: hubert+bmo)
Details
Attachments
(2 files, 1 obsolete file)
9.33 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
27.94 KB,
image/png
|
Details |
See bug 449646#c16 Some locales (I know that pt-BR needs it, but Spanish version probably needs it too) need to add "of" in the Edit Recurrence > Recurrence Pattern > Repeat annually: "15 de Agosto" (15 of August)
Updated•16 years ago
|
Attachment #333275 -
Flags: review?(philipp)
Updated•16 years ago
|
Assignee: nobody → hubert
OS: Linux → All
Hardware: PC → All
Version: Trunk → unspecified
Updated•16 years ago
|
Status: NEW → ASSIGNED
Comment 1•16 years ago
|
||
Comment on attachment 333275 [details] [diff] [review] Patch - proposal >+<!ENTITY event.recurrence.pattern.yearly.of.label "" > I'd like to see a localization note here too. >+# %1$S - day of month, %2$S - of, %3$S - month >+yearlyOrder=%1$S %2$S %3$S Please make the "of" part of the comment more descriptive. >+ <label id="yearly-period-of-month-label" >+ value="&event.recurrence.pattern.yearly.of.label;" >+ style="text-align: center" control="yearly-month-ordinal"/> Please put the style in the fitting css file. r=philipp codewise, I'll give this a test before checkin. It would be nice if you could provide me with a patch with updated comments.
Attachment #333275 -
Flags: review?(philipp) → review+
Comment 2•16 years ago
|
||
Due to the fact that this patch would cause (very) late-l10n, this should be checked in after the release.
Keywords: checkin-needed
Whiteboard: [checkin-needed after 0.9]
Assignee | ||
Comment 3•16 years ago
|
||
1. I removed style="text-align: center" - it was not needed. 2. Localization note with some examples was added - does it look better? 3. I've moved %2$S on the end in English version because there was a visible space between day of month and month 4. BTW - I've seen that someone added style to yearly-period-of-label in xul file so I moved it to css.
Attachment #333275 -
Attachment is obsolete: true
Attachment #337220 -
Flags: review?(philipp)
Assignee | ||
Comment 4•16 years ago
|
||
Comment 5•16 years ago
|
||
'checkin-needed': re-add the keyword when it is actually time to do it.
Keywords: checkin-needed
Version: unspecified → Trunk
Updated•16 years ago
|
Keywords: checkin-needed
Comment 6•16 years ago
|
||
Original patch was obsoleted, removing checkin-needed (Sorry)
Keywords: checkin-needed
Whiteboard: [checkin-needed after 0.9]
Comment 7•16 years ago
|
||
(In reply to comment #3) > 2. Localization note with some examples was added - does it look better? Thumbs up! (I noted somewhere in time that this "move to the third/last/whatever place is a bit confusing to newcomers. Unfortunately, I don't have a better idea... Just to keep that in mind.)
Comment 8•16 years ago
|
||
Comment on attachment 337220 [details] [diff] [review] Patch 0.2 Looks good, r=philipp
Attachment #337220 -
Flags: review?(philipp) → review+
Updated•16 years ago
|
Keywords: checkin-needed
Whiteboard: [checkin-needed after 0.9]
Comment 9•16 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c661dd0906ab> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [checkin-needed after 0.9]
Target Milestone: --- → 1.0
Assignee | ||
Comment 10•15 years ago
|
||
Verified on Mozilla/5.0 (X11; U; Linux i686; es-AR; rv:1.9.1b3pre) Gecko/20090127 Calendar/1.0pre
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•