450147 - Some locales need to add "of" to the yearly-period-absolute-controls in Edit Recurrence window

Status: VERIFIED FIXED

(Calendar :: General, defect)

Description

[Hubert Gajewski]

Attachment: Patch - proposal

See bug 449646#c16

Some locales (I know that pt-BR needs it, but Spanish version probably needs it too) need to add "of" in the Edit Recurrence > Recurrence Pattern > Repeat annually:
"15 de Agosto" (15 of August)

Comment 1

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 333275 [details] [diff] [review]
Patch - proposal

>+<!ENTITY event.recurrence.pattern.yearly.of.label            "" >
I'd like to see a localization note here too.


>+# %1$S - day of month, %2$S - of, %3$S - month
>+yearlyOrder=%1$S %2$S %3$S
Please make the "of" part of the comment more descriptive.

>+                        <label id="yearly-period-of-month-label"
>+                               value="&event.recurrence.pattern.yearly.of.label;"
>+                               style="text-align: center" control="yearly-month-ordinal"/>
Please put the style in the fitting css file.


r=philipp codewise, I'll give this a test before checkin. It would be nice if you could provide me with a patch with updated comments.

Comment 2

[Philipp Kewisch [:Fallen][☁️📆]]

Due to the fact that this patch would cause (very) late-l10n, this should be checked in after the release.

Comment 3

[Hubert Gajewski]

Attachment: Patch 0.2

1. I removed style="text-align: center" - it was not needed.
2. Localization note with some examples was added - does it look better?
3. I've moved %2$S on the end in English version because there was a visible space between day of month and month
4. BTW - I've seen that someone added style to yearly-period-of-label in xul file so I moved it to css.

Comment 4

[Hubert Gajewski]

Attachment: How it looks (pt-BR and en-US)

Comment 5

[Serge Gautherie (:sgautherie)]

'checkin-needed': re-add the keyword when it is actually time to do it.

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Original patch was obsoleted, removing checkin-needed (Sorry)

Comment 7

[Emerson Prado]

(In reply to comment #3)
> 2. Localization note with some examples was added - does it look better?
Thumbs up!
(I noted somewhere in time that this "move to the third/last/whatever place is a bit confusing to newcomers. Unfortunately, I don't have a better idea... Just to keep that in mind.)

Comment 8

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 337220 [details] [diff] [review]
Patch 0.2

Looks good, r=philipp

Comment 9

[Philipp Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/c661dd0906ab>

-> FIXED

Comment 10

[Hubert Gajewski]

Verified on Mozilla/5.0 (X11; U; Linux i686; es-AR; rv:1.9.1b3pre) Gecko/20090127 Calendar/1.0pre