[Mac] Temporarily turn off unified toolbar styling

RESOLVED FIXED in seamonkey2.0a1

Status

SeaMonkey
Themes
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.0a1
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Bug 439354 makes the unified toolbar look default on mac with a -moz-appearance rule in pinstripe/global/toolbar.css. Even though unified toolbar is the right thing, we should turn that off temporarily since the theme currently doesn't fit so well with the unified look (grippies, disabled buttons etc).
(Assignee)

Comment 1

10 years ago
So, looking at pinstripe/glbal/toolbar.css, the only way to get the striped look is by doing "-moz-appearance: toolbar;", right?
(Assignee)

Comment 2

10 years ago
Created attachment 333406 [details] [diff] [review]
-moz-appearance: none;
(Assignee)

Comment 3

10 years ago
Created attachment 333407 [details] [diff] [review]
-moz-appearance: toolbar;
(Assignee)

Comment 4

10 years ago
(In reply to comment #1)
> So, looking at pinstripe/glbal/toolbar.css, the only way to get the striped
> look

on Tiger
If Seamonkey currently (before bug 439354) has a striped toolbar, there must be a rule to that effect somewhere in Seamonkey land because I'm not aware of any striped toolbar rules in pinstripe/global. Maybe the Seamonkey theme stripes the toolbox and makes the toolbars translucent so that the toolbox's background shines through? If that's the case, -moz-appearance: none; would be the way to restore that behaviour.

I should probably build Seamonkey one day.
(Assignee)

Comment 6

10 years ago
Yeah, I think you're right. From what I see SeaMonkey doesn't have a striped toolbar. I'm on Leopard, though
On Tiger, SeaMonkey has a striped toolbar :-)
And the reason is that the window has -moz-appearance: dialog; and both the toolbox and the toolbar are transparent.
(Assignee)

Comment 8

10 years ago
(In reply to comment #7)
> On Tiger, SeaMonkey has a striped toolbar :-)
> And the reason is that the window has -moz-appearance: dialog; and both the
> toolbox and the toolbar are transparent.
> 
Thanks - right, I forgot about the dialog.
(Assignee)

Comment 9

10 years ago
Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

Karsten, since we expect bug 439354 to be landed today, before the freeze, can you tale a quick look at this? This will restore the old behaviour and it can be landed before bug 439354 lands.
Attachment #333406 - Flags: review?(mnyromyr)
(Assignee)

Comment 10

10 years ago
Actually, from reading https://bugzilla.mozilla.org/show_bug.cgi?id=432131#c47 (which has to land before bug 439354) nothing will happen with bug 439354 today.
(Assignee)

Comment 11

10 years ago
(Karsten will look at this when the dependent bug gets fixed and if I'm away he'll land the patch)

Updated

10 years ago
Attachment #333406 - Flags: review?(mnyromyr) → review+
(Assignee)

Comment 12

10 years ago
Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

This just makes sm look "as usual" - other parts of the ui needs some re-styling before sm can have a unified toolbar.
Attachment #333406 - Flags: approval-seamonkey2.0a1?
(Assignee)

Updated

10 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.0alpha

Comment 13

10 years ago
Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

yes, let's do this for now, and come up with a good unified look hopefully for alpha 2.
Attachment #333406 - Flags: approval-seamonkey2.0a1? → approval-seamonkey2.0a1+
(Assignee)

Comment 14

10 years ago
http://hg.mozilla.org/comm-central/rev/190d8aa1c9d7
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.