450261 - [Mac] Temporarily turn off unified toolbar styling

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Bug 439354 makes the unified toolbar look default on mac with a -moz-appearance rule in pinstripe/global/toolbar.css. Even though unified toolbar is the right thing, we should turn that off temporarily since the theme currently doesn't fit so well with the unified look (grippies, disabled buttons etc).

Comment 1

[Stefan [:stefanh]]

So, looking at pinstripe/glbal/toolbar.css, the only way to get the striped look is by doing "-moz-appearance: toolbar;", right?

Comment 2

[Stefan [:stefanh]]

Attachment: -moz-appearance: none;

Comment 3

[Stefan [:stefanh]]

Attachment: -moz-appearance: toolbar;

Comment 4

[Stefan [:stefanh]]

(In reply to comment #1)
> So, looking at pinstripe/glbal/toolbar.css, the only way to get the striped
> look

on Tiger

Comment 5

[Markus Stange [:mstange]]

If Seamonkey currently (before bug 439354) has a striped toolbar, there must be a rule to that effect somewhere in Seamonkey land because I'm not aware of any striped toolbar rules in pinstripe/global. Maybe the Seamonkey theme stripes the toolbox and makes the toolbars translucent so that the toolbox's background shines through? If that's the case, -moz-appearance: none; would be the way to restore that behaviour.

I should probably build Seamonkey one day.

Comment 6

[Stefan [:stefanh]]

Yeah, I think you're right. From what I see SeaMonkey doesn't have a striped toolbar. I'm on Leopard, though

Comment 7

[Markus Stange [:mstange]]

On Tiger, SeaMonkey has a striped toolbar :-)
And the reason is that the window has -moz-appearance: dialog; and both the toolbox and the toolbar are transparent.

Comment 8

[Stefan [:stefanh]]

(In reply to comment #7)
> On Tiger, SeaMonkey has a striped toolbar :-)
> And the reason is that the window has -moz-appearance: dialog; and both the
> toolbox and the toolbar are transparent.
> 
Thanks - right, I forgot about the dialog.

Comment 9

[Stefan [:stefanh]]

Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

Karsten, since we expect bug 439354 to be landed today, before the freeze, can you tale a quick look at this? This will restore the old behaviour and it can be landed before bug 439354 lands.

Comment 10

[Stefan [:stefanh]]

Actually, from reading https://bugzilla.mozilla.org/show_bug.cgi?id=432131#c47 (which has to land before bug 439354) nothing will happen with bug 439354 today.

Comment 11

[Stefan [:stefanh]]

(Karsten will look at this when the dependent bug gets fixed and if I'm away he'll land the patch)

Comment 12

[Stefan [:stefanh]]

Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

This just makes sm look "as usual" - other parts of the ui needs some re-styling before sm can have a unified toolbar.

Comment 13

[Robert Kaiser]

Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

yes, let's do this for now, and come up with a good unified look hopefully for alpha 2.

Comment 14

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/190d8aa1c9d7