Closed Bug 450261 Opened 13 years ago Closed 13 years ago

[Mac] Temporarily turn off unified toolbar styling

Categories

(SeaMonkey :: Themes, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0a1

People

(Reporter: stefanh, Assigned: stefanh)

References

Details

Attachments

(2 files)

Bug 439354 makes the unified toolbar look default on mac with a -moz-appearance rule in pinstripe/global/toolbar.css. Even though unified toolbar is the right thing, we should turn that off temporarily since the theme currently doesn't fit so well with the unified look (grippies, disabled buttons etc).
So, looking at pinstripe/glbal/toolbar.css, the only way to get the striped look is by doing "-moz-appearance: toolbar;", right?
(In reply to comment #1)
> So, looking at pinstripe/glbal/toolbar.css, the only way to get the striped
> look

on Tiger
If Seamonkey currently (before bug 439354) has a striped toolbar, there must be a rule to that effect somewhere in Seamonkey land because I'm not aware of any striped toolbar rules in pinstripe/global. Maybe the Seamonkey theme stripes the toolbox and makes the toolbars translucent so that the toolbox's background shines through? If that's the case, -moz-appearance: none; would be the way to restore that behaviour.

I should probably build Seamonkey one day.
Yeah, I think you're right. From what I see SeaMonkey doesn't have a striped toolbar. I'm on Leopard, though
On Tiger, SeaMonkey has a striped toolbar :-)
And the reason is that the window has -moz-appearance: dialog; and both the toolbox and the toolbar are transparent.
(In reply to comment #7)
> On Tiger, SeaMonkey has a striped toolbar :-)
> And the reason is that the window has -moz-appearance: dialog; and both the
> toolbox and the toolbar are transparent.
> 
Thanks - right, I forgot about the dialog.
Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

Karsten, since we expect bug 439354 to be landed today, before the freeze, can you tale a quick look at this? This will restore the old behaviour and it can be landed before bug 439354 lands.
Attachment #333406 - Flags: review?(mnyromyr)
Actually, from reading https://bugzilla.mozilla.org/show_bug.cgi?id=432131#c47 (which has to land before bug 439354) nothing will happen with bug 439354 today.
(Karsten will look at this when the dependent bug gets fixed and if I'm away he'll land the patch)
Attachment #333406 - Flags: review?(mnyromyr) → review+
Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

This just makes sm look "as usual" - other parts of the ui needs some re-styling before sm can have a unified toolbar.
Attachment #333406 - Flags: approval-seamonkey2.0a1?
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.0alpha
Comment on attachment 333406 [details] [diff] [review]
-moz-appearance: none;

yes, let's do this for now, and come up with a good unified look hopefully for alpha 2.
Attachment #333406 - Flags: approval-seamonkey2.0a1? → approval-seamonkey2.0a1+
http://hg.mozilla.org/comm-central/rev/190d8aa1c9d7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.