Closed
Bug 450265
Opened 17 years ago
Closed 17 years ago
Make theora build with VC7.1
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: neil, Assigned: neil)
Details
Attachments
(1 file)
|
480 bytes,
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
Theora uses a varadic macro that won't compile with VC7.1
|
Assignee | |
Comment 1•17 years ago
|
||
This just disables theora debugging in VC7.1
Attachment #333424 -
Flags: review?(chris.double)
Attachment #333424 -
Flags: review?(benjamin)
|
||
Comment 2•17 years ago
|
||
This is also fixed in a later changeset to libtheora:
https://trac.xiph.org/changeset/15153
Although the changes there are more pervasive.
Can you add a note to README_MOZILLA to note the change (maybe just point to this bug), so if I refresh the source I don't lose it.
|
|
||
Updated•17 years ago
|
Attachment #333424 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → neil
|
|
Assignee | |
Comment 3•17 years ago
|
||
Pushed changeset 3faeabe48663 to mozilla-central.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Attachment #333424 -
Flags: review?(benjamin)
You need to log in
before you can comment on or make changes to this bug.
Description
•