Closed Bug 450265 Opened 15 years ago Closed 15 years ago

Make theora build with VC7.1

Categories

(Core :: Audio/Video, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file)

Theora uses a varadic macro that won't compile with VC7.1
Attached patch workaroundSplinter Review
This just disables theora debugging in VC7.1
Attachment #333424 - Flags: review?(chris.double)
Attachment #333424 - Flags: review?(benjamin)
This is also fixed in a later changeset to libtheora:

https://trac.xiph.org/changeset/15153

Although the changes there are more pervasive.

Can you add a note to README_MOZILLA to note the change (maybe just point to this bug), so if I refresh the source I don't lose it.
Attachment #333424 - Flags: review?(chris.double) → review+
Assignee: nobody → neil
Pushed changeset 3faeabe48663 to mozilla-central.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Attachment #333424 - Flags: review?(benjamin)
You need to log in before you can comment on or make changes to this bug.