450270 - NewAPI: Add modal windows support for Qt

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, defect)

Description

[Pelle Johnsen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: 

Add support for handling modal windows in the Qt part of the New Embedding API. This is needed for making prompts work correctly. Will add patch shortly.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Pelle Johnsen]

Attachment: Patch to add support for modal windows on Qt

Added patch against hg.mozilla.org/incubator/embedding

Comment 2

[Pelle Johnsen]

Comment on attachment 333415 [details] [diff] [review]
Patch to add support for modal windows on Qt

mfinkle: would you like to take a quick look at this before I commit?

Comment 3

[Pelle Johnsen]

Attachment: Updated patch, avoid dealing with modal in openWindow

Added updated patch

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 333776 [details] [diff] [review]
Updated patch, avoid dealing with modal in openWindow

>diff --git a/qt/QMozView.cpp b/qt/QMozView.cpp

>+  void ShowAsModal();
>+  void ExitModal(nsresult result);

Instead of ShowAsModal can we call it StartModal? fits better with ExitModal and gives more context that this is less about showing a window and more about a modal loop.

If you agree, remember to change the other variants too.

r+ either way

Comment 5

[Pelle Johnsen]

Pushed with name change ShowAsModal -> StartModal