450341 - Remove the typeof operator

Status: RESOLVED WORKSFORME

(Core :: XPCOM, defect)

Description

[Bo Yang]

Attachment: The proposal patch

The typeof operator is used to deal with the situation that we can't declare a function pointer to member function with __attribute__ in some version of GCC. And now the the operator itself may be broken and there is patch for repairing the member function pointer problem is under discuss. So, remove the typeof may be better.

Comment 1

[Benjamin Smedberg]

Comment on attachment 333490 [details] [diff] [review]
The proposal patch

Does this syntax work with older (3.3/3.4) versions of GCC? I'm going to put it through a tryserver run also.

Comment 2

[Bo Yang]

(In reply to comment #1)
> (From update of attachment 333490 [details] [diff] [review])
> Does this syntax work with older (3.3/3.4) versions of GCC? I'm going to put it
> through a tryserver run also.

Both 3.4.1 and 3.4.2 supports this syntax and works well but 3.3.5 does not support this syntax.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

bsmedberg, should anything still block this from landing?

Comment 4

[Benjamin Smedberg]

Do we need it? I know that GCC 4.2 had problems where stdcall function pointers didn't generate correct code, and since that probably affects MacOS I don't think we should try to land this unless 1) we need it and 2) it's tested thoroughly.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:nika, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Pretty sure this code is gone at this point