450437 - duplicate URLs dropped when bookmarking all tabs

Status: RESOLVED INACTIVE

(Firefox :: Bookmarks & History, defect)

Description

[Simon Bünzli]

Steps to Reproduce:
1. Open Google's homepage twice
2. Bookmark all tabs (Ctrl+Shift+D and Enter)

Expected result:
Two Google bookmarks inside a folder named "[Folder Name]".

Actual result:
Only one bookmark inside that new folder.

The current behavior might prevent duplicate bookmarks, it however violates the principle of least surprise (imagine you had the same URL open in two tabs about 50 tabs across - in two different contexts - and now one of them's suddenly missing).


BTW: Shouldn't Places and Bookmarks&History be the same component (resp. Places be moved to Toolkit)? The difference between the two components is currently quite hard to tell.

Comment 1

[Paul J. Weiss]

(In reply to comment #0)
> BTW: Shouldn't Places and Bookmarks&History be the same component (resp. Places
> be moved to Toolkit)? The difference between the two components is currently
> quite hard to tell.

That has been reported as bug 451915.

Comment 2

[Paul J. Weiss]

I agree that the deduping is a problem. I do sometimes have one URL in multiple tabs on purpose.

Comment 3

[Dietrich Ayala (:dietrich)]

I'd really like to see this fixed, but wouldn't hold the release for it: blocking-.

Comment 4

[Adam]

Attachment: Convert get uniqueCurrentPages to get currentPages

Only this feature and related tests used the uniqueCurrentPages getter, so this patch just converts it so it no longer filters for uniqueness.

Comment 5

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.