450438 - Password autofill is putting usernames in fields that it shouldn't

Status: RESOLVED DUPLICATE of bug 432806

(Toolkit :: Password Manager, defect)

Description

[Shawn Hampton]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1

If a username/password is saved for a site, and another page has a password field, but not the same username field, the value of the username field is applied to that field.

seems similar to https://bugzilla.mozilla.org/show_bug.cgi?id=270558

Reproducible: Always

Steps to Reproduce:
1.visit http://grrrargh.com/firefoxFormBug/page1.html
2.fill in any username/password combo and click submit
3.save password
4.reload the second page which has a password and phone field 
Actual Results:  
the username is filled into the phone field

Expected Results:  
empty form fields

Comment 1

[Simon Bünzli]

The reason: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/components/passwordmgr/src/nsLoginInfo.js&rev=1.6&mark=92#92

Comment 2

[Simon Bünzli]

Comparing with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.16) Gecko/20080702 Firefox/2.0.0.16, the behavior for page2.html is now improved (we used to only get a password filled in), for page3.html it's a regression, though.

Comment 3

[Justin Dolske [:Dolske]]

This wasn't regressed by bug 397799. The FF3 password manager doesn't use form fields name when filling in logins. This is by design -- keying off the name attribute was failure prone when different pages on a site used different field names.