Closed
Bug 450467
Opened 17 years ago
Closed 17 years ago
application.ini name must match X-Osso-Service
Categories
(Firefox for Android Graveyard :: General, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0m7
People
(Reporter: dougt, Assigned: blassey)
References
Details
Attachments
(3 files, 4 obsolete files)
1.17 KB,
patch
|
Details | Diff | Splinter Review | |
1.19 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
1.16 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
when you define a X-Osso-Service on maemo, it must match the name of the application you define in application.ini. If you do not make this match, the dbus service will kill your application
Assignee | ||
Comment 1•17 years ago
|
||
Assignee | ||
Comment 2•17 years ago
|
||
Attachment #333629 -
Flags: review?(ted.mielczarek)
Reporter | ||
Comment 3•17 years ago
|
||
fixes up toolkit xre to use vendor and app name.
Attachment #333631 -
Flags: review?(benjamin)
Updated•17 years ago
|
Attachment #333631 -
Flags: review?(benjamin) → review+
Comment 4•17 years ago
|
||
Comment on attachment 333628 [details] [diff] [review]
uses variables for consistancy
> ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
>
>-APP_NAME = $(MOZ_APP_DISPLAYNAME)
>+APP_NAME = $(MOZ_APP_NAME)
Leave this one alone. It is the name of the Mac bundle/DMG
>diff --git a/installer/debian/fennec.desktop.in b/installer/debian/fennec.desktop.in
> Encoding=UTF-8
>-Name=Fennec
>+Name=@MOZ_APP_DISPLAYNAME@
> Comment=Fennec mobile browser
> GenericName=Fennec
This one too? MOZ_APP_DISPLAYNAME
>-StartupWMClass=Fennec
>+StartupWMClass=@MOZ_APP_NAME@
This is "fennec", not "Fennec" - is that ok?
>-X-Osso-Service=org.mozilla.fennec
>-GenericName[it_IT]=Mobile Browser
>+X-Osso-Service=@MOZ_APP_VENDOR@.@MOZ_APP_NAME@
>+GenericName[it_IT]=@MOZ_APP_NAME@
Shouldn't this be MOZ_APP_DISPLAYNAME ? and why do we have Italian here? (I assume it's Italian)
Attachment #333628 -
Flags: review?(mark.finkle) → review-
Assignee | ||
Comment 5•17 years ago
|
||
Attachment #333628 -
Attachment is obsolete: true
Attachment #333679 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 6•17 years ago
|
||
> >diff --git a/installer/debian/fennec.desktop.in b/installer/debian/fennec.desktop.in
> > Encoding=UTF-8
> >-Name=Fennec
> >+Name=@MOZ_APP_DISPLAYNAME@
> > Comment=Fennec mobile browser
> > GenericName=Fennec
>
> This one too? MOZ_APP_DISPLAYNAME
I think we want the label on the menu to be capitalized
>
> >-StartupWMClass=Fennec
> >+StartupWMClass=@MOZ_APP_NAME@
>
> This is "fennec", not "Fennec" - is that ok?
I think its okay, but just to be safe...
>
> >-X-Osso-Service=org.mozilla.fennec
> >-GenericName[it_IT]=Mobile Browser
> >+X-Osso-Service=@MOZ_APP_VENDOR@.@MOZ_APP_NAME@
> >+GenericName[it_IT]=@MOZ_APP_NAME@
>
> Shouldn't this be MOZ_APP_DISPLAYNAME ? and why do we have Italian here? (I
> assume it's Italian)
I'm not sure. On this point, I'm just copying what debian has for iceweasel.
However, X-Osso-Service needs to be @MOZ_APP_VENDOR@.@MOZ_APP_DISPLAYNAME@ to be consistent with application.ini
Assignee | ||
Comment 7•17 years ago
|
||
Attachment #333679 -
Attachment is obsolete: true
Attachment #333686 -
Flags: review?(mark.finkle)
Attachment #333679 -
Flags: review?(mark.finkle)
Updated•17 years ago
|
Attachment #333686 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 8•17 years ago
|
||
the service name in fennec.desktop and fennec.service need to match
Attachment #333867 -
Flags: review?
Reporter | ||
Comment 9•17 years ago
|
||
Comment on attachment 333867 [details] [diff] [review]
makes the same change to the service name in fennec.service
just what I asked for. thanks.
Attachment #333867 -
Flags: review? → review+
Reporter | ||
Comment 10•17 years ago
|
||
Comment on attachment 333631 [details] [diff] [review]
fixes up toolkit xre to use vendor and app name.
this part landed.
dougt@mozilla.com
Thu Aug 14 19:37:03 2008 -0700 c652d1311eec Doug Turner — bug 450467. on OSSO, use vendor and app name when calling osso_init. r=bsmedberg default tip
Updated•17 years ago
|
Flags: blocking-fennec1.0+
Priority: -- → P1
Target Milestone: --- → Fennec M7
Reporter | ||
Comment 11•17 years ago
|
||
bsmedberg and I do not believe we need MOZ_APP_VENDOR. I committed 5cde8fc839f8 which includes a hardcoded version name.
If we want a dynamic vendor, lets file a separate patch.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 12•17 years ago
|
||
I'm reopening this bug because that push hard coded the application name as well. Also the changes to application.ini and fennec.desktop haven't landed (and need to be modified to get rid of the vendor tag).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 13•17 years ago
|
||
Attachment #333686 -
Attachment is obsolete: true
Attachment #333867 -
Attachment is obsolete: true
Attachment #333962 -
Flags: review?(mark.finkle)
Updated•17 years ago
|
Attachment #333962 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 14•17 years ago
|
||
pushed changeset 704f5401f1f8
http://hg.mozilla.org/mobile-browser/index.cgi/rev/704f5401f1f8
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Comment 15•17 years ago
|
||
Comment on attachment 333629 [details] [diff] [review]
adds MOZ_APP_VENDOR
Clearing review request based on previous comments.
Attachment #333629 -
Flags: review?(ted.mielczarek)
Comment 16•16 years ago
|
||
debian installer has been working well for quite some time. Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•