Closed Bug 450467 Opened 12 years ago Closed 12 years ago

application.ini name must match X-Osso-Service

Categories

(Firefox for Android Graveyard :: General, defect, P1)

x86
macOS
defect

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0m7

People

(Reporter: dougt, Assigned: blassey)

References

Details

Attachments

(3 files, 4 obsolete files)

when you define a X-Osso-Service on maemo, it must match the name of the application you define in application.ini.  If you do not make this match, the dbus service will kill your application
Blocks: 450443
Attached patch uses variables for consistancy (obsolete) — Splinter Review
Assignee: nobody → blassey
Status: NEW → ASSIGNED
Attachment #333628 - Flags: review?(mark.finkle)
Attachment #333629 - Flags: review?(ted.mielczarek)
fixes up toolkit xre to use vendor and app name.
Attachment #333631 - Flags: review?(benjamin)
Attachment #333631 - Flags: review?(benjamin) → review+
Comment on attachment 333628 [details] [diff] [review]
uses variables for consistancy

> ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
> 
>-APP_NAME = $(MOZ_APP_DISPLAYNAME)
>+APP_NAME = $(MOZ_APP_NAME)

Leave this one alone. It is the name of the Mac bundle/DMG

>diff --git a/installer/debian/fennec.desktop.in b/installer/debian/fennec.desktop.in
> Encoding=UTF-8
>-Name=Fennec
>+Name=@MOZ_APP_DISPLAYNAME@
> Comment=Fennec mobile browser
> GenericName=Fennec

This one too? MOZ_APP_DISPLAYNAME

>-StartupWMClass=Fennec
>+StartupWMClass=@MOZ_APP_NAME@

This is "fennec", not "Fennec" - is that ok?

>-X-Osso-Service=org.mozilla.fennec
>-GenericName[it_IT]=Mobile Browser
>+X-Osso-Service=@MOZ_APP_VENDOR@.@MOZ_APP_NAME@
>+GenericName[it_IT]=@MOZ_APP_NAME@

Shouldn't this be MOZ_APP_DISPLAYNAME ? and why do we have Italian here? (I assume it's Italian)
Attachment #333628 - Flags: review?(mark.finkle) → review-
Attached patch updated (obsolete) — Splinter Review
Attachment #333628 - Attachment is obsolete: true
Attachment #333679 - Flags: review?(mark.finkle)
> >diff --git a/installer/debian/fennec.desktop.in b/installer/debian/fennec.desktop.in
> > Encoding=UTF-8
> >-Name=Fennec
> >+Name=@MOZ_APP_DISPLAYNAME@
> > Comment=Fennec mobile browser
> > GenericName=Fennec
> 
> This one too? MOZ_APP_DISPLAYNAME

I think we want the label on the menu to be capitalized 

> 
> >-StartupWMClass=Fennec
> >+StartupWMClass=@MOZ_APP_NAME@
> 
> This is "fennec", not "Fennec" - is that ok?

I think its okay, but just to be safe...

> 
> >-X-Osso-Service=org.mozilla.fennec
> >-GenericName[it_IT]=Mobile Browser
> >+X-Osso-Service=@MOZ_APP_VENDOR@.@MOZ_APP_NAME@
> >+GenericName[it_IT]=@MOZ_APP_NAME@
> 
> Shouldn't this be MOZ_APP_DISPLAYNAME ? and why do we have Italian here? (I
> assume it's Italian)

I'm not sure. On this point, I'm just copying what debian has for iceweasel.

However, X-Osso-Service needs to be @MOZ_APP_VENDOR@.@MOZ_APP_DISPLAYNAME@ to be consistent with application.ini


Attached patch updated based on irc conv (obsolete) — Splinter Review
Attachment #333679 - Attachment is obsolete: true
Attachment #333686 - Flags: review?(mark.finkle)
Attachment #333679 - Flags: review?(mark.finkle)
Attachment #333686 - Flags: review?(mark.finkle) → review+
the service name in fennec.desktop and fennec.service need to match
Attachment #333867 - Flags: review?
Comment on attachment 333867 [details] [diff] [review]
makes the same change to the service name in fennec.service

just what I asked for.  thanks.
Attachment #333867 - Flags: review? → review+
Comment on attachment 333631 [details] [diff] [review]
fixes up toolkit xre to use vendor and app name.

this part landed.

dougt@mozilla.com
Thu Aug 14 19:37:03 2008 -0700	c652d1311eec	Doug Turner — bug 450467. on OSSO, use vendor and app name when calling osso_init. r=bsmedberg default tip
Flags: blocking-fennec1.0+
Priority: -- → P1
Target Milestone: --- → Fennec M7
bsmedberg and I do not believe we need MOZ_APP_VENDOR.  I committed 5cde8fc839f8 which includes a hardcoded version name.

If we want a dynamic vendor, lets file a separate patch.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I'm reopening this bug because that push hard coded the application name as well.  Also the changes to application.ini and fennec.desktop haven't landed (and need to be modified to get rid of the vendor tag).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #333686 - Attachment is obsolete: true
Attachment #333867 - Attachment is obsolete: true
Attachment #333962 - Flags: review?(mark.finkle)
Attachment #333962 - Flags: review?(mark.finkle) → review+
pushed changeset 704f5401f1f8
http://hg.mozilla.org/mobile-browser/index.cgi/rev/704f5401f1f8
Status: REOPENED → RESOLVED
Closed: 12 years ago12 years ago
Resolution: --- → FIXED
Comment on attachment 333629 [details] [diff] [review]
adds MOZ_APP_VENDOR

Clearing review request based on previous comments.
Attachment #333629 - Flags: review?(ted.mielczarek)
debian installer has been working well for quite some time.  Marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.