450467 - application.ini name must match X-Osso-Service

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Doug Turner (:dougt)]

when you define a X-Osso-Service on maemo, it must match the name of the application you define in application.ini.  If you do not make this match, the dbus service will kill your application

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: uses variables for consistancy

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: adds MOZ_APP_VENDOR

Comment 3

[Doug Turner (:dougt)]

Attachment: fixes up toolkit xre to use vendor and app name.

fixes up toolkit xre to use vendor and app name.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 333628 [details] [diff] [review]
uses variables for consistancy

> ifneq (,$(filter mac cocoa,$(MOZ_WIDGET_TOOLKIT)))
> 
>-APP_NAME = $(MOZ_APP_DISPLAYNAME)
>+APP_NAME = $(MOZ_APP_NAME)

Leave this one alone. It is the name of the Mac bundle/DMG

>diff --git a/installer/debian/fennec.desktop.in b/installer/debian/fennec.desktop.in
> Encoding=UTF-8
>-Name=Fennec
>+Name=@MOZ_APP_DISPLAYNAME@
> Comment=Fennec mobile browser
> GenericName=Fennec

This one too? MOZ_APP_DISPLAYNAME

>-StartupWMClass=Fennec
>+StartupWMClass=@MOZ_APP_NAME@

This is "fennec", not "Fennec" - is that ok?

>-X-Osso-Service=org.mozilla.fennec
>-GenericName[it_IT]=Mobile Browser
>+X-Osso-Service=@MOZ_APP_VENDOR@.@MOZ_APP_NAME@
>+GenericName[it_IT]=@MOZ_APP_NAME@

Shouldn't this be MOZ_APP_DISPLAYNAME ? and why do we have Italian here? (I assume it's Italian)

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: updated

Comment 6

[Brad Lassey [:blassey] (use needinfo?)]

> >diff --git a/installer/debian/fennec.desktop.in b/installer/debian/fennec.desktop.in
> > Encoding=UTF-8
> >-Name=Fennec
> >+Name=@MOZ_APP_DISPLAYNAME@
> > Comment=Fennec mobile browser
> > GenericName=Fennec
> 
> This one too? MOZ_APP_DISPLAYNAME

I think we want the label on the menu to be capitalized 

> 
> >-StartupWMClass=Fennec
> >+StartupWMClass=@MOZ_APP_NAME@
> 
> This is "fennec", not "Fennec" - is that ok?

I think its okay, but just to be safe...

> 
> >-X-Osso-Service=org.mozilla.fennec
> >-GenericName[it_IT]=Mobile Browser
> >+X-Osso-Service=@MOZ_APP_VENDOR@.@MOZ_APP_NAME@
> >+GenericName[it_IT]=@MOZ_APP_NAME@
> 
> Shouldn't this be MOZ_APP_DISPLAYNAME ? and why do we have Italian here? (I
> assume it's Italian)

I'm not sure. On this point, I'm just copying what debian has for iceweasel.

However, X-Osso-Service needs to be @MOZ_APP_VENDOR@.@MOZ_APP_DISPLAYNAME@ to be consistent with application.ini

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: updated based on irc conv

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: makes the same change to the service name in fennec.service

the service name in fennec.desktop and fennec.service need to match

Comment 9

[Doug Turner (:dougt)]

Comment on attachment 333867 [details] [diff] [review]
makes the same change to the service name in fennec.service

just what I asked for.  thanks.

Comment 10

[Doug Turner (:dougt)]

Comment on attachment 333631 [details] [diff] [review]
fixes up toolkit xre to use vendor and app name.

this part landed.

[e-mail]
Thu Aug 14 19:37:03 2008 -0700	c652d1311eec	Doug Turner — bug 450467. on OSSO, use vendor and app name when calling osso_init. r=bsmedberg default tip

Comment 11

[Doug Turner (:dougt)]

bsmedberg and I do not believe we need MOZ_APP_VENDOR.  I committed 5cde8fc839f8 which includes a hardcoded version name.

If we want a dynamic vendor, lets file a separate patch.

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

I'm reopening this bug because that push hard coded the application name as well.  Also the changes to application.ini and fennec.desktop haven't landed (and need to be modified to get rid of the vendor tag).

Comment 13

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: drops vendor changes

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

pushed changeset 704f5401f1f8
http://hg.mozilla.org/mobile-browser/index.cgi/rev/704f5401f1f8

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 333629 [details] [diff] [review]
adds MOZ_APP_VENDOR

Clearing review request based on previous comments.

Comment 16

[Joel Maher ( :jmaher ) (UTC-4) (back Feb 19th)]

debian installer has been working well for quite some time.  Marking as verified.