Closed
Bug 450502
Opened 17 years ago
Closed 17 years ago
nsNavHistoryExpire::ClearHistory has a defective query
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: sdwilsh, Assigned: mak)
References
()
Details
The first query in nsNavHistoryExpire::ClearHistory is missing a closing paren. It'll always not work. Consequentially, it means we don't have a unit test for this code path!
Flags: in-testsuite?
|
Assignee | |
Updated•17 years ago
|
Assignee: nobody → mak77
|
|
Assignee | |
Updated•17 years ago
|
Flags: blocking1.9.1?
|
Reporter | |
Comment 1•17 years ago
|
||
This probably has never been caught because we just issue an NS_WARNING if the query fails. There's really no reason to issue a warning like that though, and we should probably use NS_ENSURE_SUCCESS
|
|
Assignee | |
Comment 2•17 years ago
|
||
note: also add a test for reset frecency query in EraseVisits
|
|
Assignee | |
Comment 3•17 years ago
|
||
the query has been fixed by fsync stuff, this needs only a test
|
|
Assignee | |
Comment 5•17 years ago
|
||
no more blocking since bug is fixed, missing only tests
Flags: blocking1.9.1?
Whiteboard: [needs test]
|
|
Assignee | |
Comment 6•17 years ago
|
||
test pushed with bug 463471
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•17 years ago
|
Target Milestone: mozilla1.9.1a2 → mozilla1.9.1b2
|
|
Assignee | |
Updated•17 years ago
|
Flags: in-testsuite? → in-testsuite+
Whiteboard: [needs test]
You need to log in
before you can comment on or make changes to this bug.
Description
•