Closed Bug 450543 Opened 16 years ago Closed 8 years ago

Use the toolkit feed parsing service for RSS

Categories

(MailNews Core :: Feed Reader, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: philor, Unassigned)

References

Details

(Whiteboard: [patchlove][has draft patch][needs new assignee])

Attachments

(1 file, 4 obsolete files)

The toolkit feed parser comes with a squillion tests, a fair number of people banging on it and patching it, and we're already building and shipping it, just not using it; ours comes with zero tests, a fair number of known bugs, and very little love. We should just switch.
Flags: wanted-thunderbird3+
jminta has a partial patch, I believe...
Assignee: nobody → jminta
Joey, can you post what you've got to the bug?  I'm hoping someone else would be interested in picking it up and running with it...
Priority: -- → P2
Target Milestone: --- → Thunderbird 3.0b1
Just heard out-of-band from Joey that he probably won't be able to post this for about a week.
shifting milestone in response to comment #3
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
Attached file work in progress (obsolete) —
This is the current status of my work here. This is meant to be a new component to handle most of the feed work. The main remaining items are: (1) wiring back in the feed->msf conversion code (2) wiring the UI for feed management up to the new code (3) bug fixing (this code is completely untested at this point).
alta88, is this something you'd be interested in taking on and driving into the tree?
Attached patch more wip (obsolete) — Splinter Review
This one actually migrates your old feed settings to the new db, and *kinda* opens the subscription window with that data. Still need to wire in the downloading/display, as well as restoring feed-modification functions.
Attachment #343760 - Attachment is obsolete: true
Attached patch wip3 (obsolete) — Splinter Review
Another checkpoint. downloadFeed sorta works here.
Attachment #349656 - Attachment is obsolete: true
Joey, now that b2 is pushed back, is there enough progress this might this make b2?   (there is also b3)

this bug, plus bug 471932, will make a huge dent in RSS problems.
Status: NEW → ASSIGNED
Attached patch wip4 (obsolete) — Splinter Review
I'm putting up another checkpoint here, because the architecture changes are mostly done in this one. With this patch, I can create an rss account, add a feed subscription, and if I get the Get Mail button, it will download, parse, and display the feed (in some rough sense). Still not to the dogfood level, but the overall shape of what I'm aiming for should finally start to become clear.
Attachment #350569 - Attachment is obsolete: true
Blocks: 476641
Component: RSS → Feed Reader
Product: Thunderbird → MailNews Core
Target Milestone: Thunderbird 3.0b1 → ---
Attached patch wip5Splinter Review
Finally escaped from the legal world long enough to dive back into this for a bit. This patch has import/export working, along with better feed->msf translation and more robust migration of old feed settings. Still a decent amount of work to be done, but I'm hoping to have something worth testing by the end of the week.
Attachment #358494 - Attachment is obsolete: true
Hmm, looks like a bitrot race compared to my goal of moving nsRssIncomingServer into JS.

In any case, I'm most concerned about migration here, especially given the propensity with which feeds.rdf can become corrupted.
Blocks: 637155
Assignee: jminta → nobody
(In reply to comment #14)
> Hmm, looks like a bitrot race compared to my goal of moving nsRssIncomingServer
> into JS.
> 
> In any case, I'm most concerned about migration here, especially given the
> propensity with which feeds.rdf can become corrupted.

indeed. And, bug 471932 would still need to be addressed?

another set of major bugs https://bugzilla.mozilla.org/buglist.cgi?negate0=1&query_format=advanced&field0-0-0=short_desc&bug_severity=major&type0-0-0=nowordssubstr&value0-0-0=crash%20subscri%20list%20dupli%20Summary%20delet%20folder&component=Feed%20Reader&resolution=---&product=MailNews%20Core&product=Thunderbird
Blocks: 390351, 388919
Status: ASSIGNED → NEW
Summary: Use the toolkit feed parsing service → Use the toolkit feed parsing service for RSS
Whiteboard: [patchlove][has draft patch][needs new assignee]
No longer blocks: 388919
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
Closing for these reasons:
1. Given the state of things with Tb and Moz, creating this dependency is bad strategy. No one in toolkit wants to own the feed code for Fx and will unlikely be responsive to Tb.
2. The toolkit code is one huge COMtaminated object, even according to its author[1], the great Mr. Atom himself.
3. The Tb feed parser is very simple, self contained, and just works for what Tb needs.
4. No one is going to do this work, and rightly so.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=525655#c7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.