Closed
Bug 450543
Opened 16 years ago
Closed 8 years ago
Use the toolkit feed parsing service for RSS
Categories
(MailNews Core :: Feed Reader, defect, P2)
MailNews Core
Feed Reader
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: philor, Unassigned)
References
Details
(Whiteboard: [patchlove][has draft patch][needs new assignee])
Attachments
(1 file, 4 obsolete files)
207.28 KB,
patch
|
Details | Diff | Splinter Review |
The toolkit feed parser comes with a squillion tests, a fair number of people banging on it and patching it, and we're already building and shipping it, just not using it; ours comes with zero tests, a fair number of known bugs, and very little love. We should just switch.
Flags: wanted-thunderbird3+
Comment 2•16 years ago
|
||
Joey, can you post what you've got to the bug? I'm hoping someone else would be interested in picking it up and running with it...
Priority: -- → P2
Target Milestone: --- → Thunderbird 3.0b1
Comment 3•16 years ago
|
||
Just heard out-of-band from Joey that he probably won't be able to post this for about a week.
Comment 4•16 years ago
|
||
shifting milestone in response to comment #3
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
Comment 5•16 years ago
|
||
This is the current status of my work here. This is meant to be a new component to handle most of the feed work. The main remaining items are: (1) wiring back in the feed->msf conversion code (2) wiring the UI for feed management up to the new code (3) bug fixing (this code is completely untested at this point).
Comment 6•16 years ago
|
||
alta88, is this something you'd be interested in taking on and driving into the tree?
Comment 7•16 years ago
|
||
This one actually migrates your old feed settings to the new db, and *kinda* opens the subscription window with that data. Still need to wire in the downloading/display, as well as restoring feed-modification functions.
Attachment #343760 -
Attachment is obsolete: true
Comment 8•16 years ago
|
||
Another checkpoint. downloadFeed sorta works here.
Attachment #349656 -
Attachment is obsolete: true
Comment 9•15 years ago
|
||
Joey, now that b2 is pushed back, is there enough progress this might this make b2? (there is also b3) this bug, plus bug 471932, will make a huge dent in RSS problems.
Status: NEW → ASSIGNED
Comment 10•15 years ago
|
||
I'm putting up another checkpoint here, because the architecture changes are mostly done in this one. With this patch, I can create an rss account, add a feed subscription, and if I get the Get Mail button, it will download, parse, and display the feed (in some rough sense). Still not to the dogfood level, but the overall shape of what I'm aiming for should finally start to become clear.
Attachment #350569 -
Attachment is obsolete: true
Comment 11•15 years ago
|
||
some bugs to check once this lands https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=&long_desc_type=anywordssubstr&long_desc=interval+check+updat+refresh++minute&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&product=Thunderbird&component=RSS&resolution=---&bug_severity=major&bug_severity=normal&bug_severity=minor&emailreporter1=1&emailtype1=substring&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=substring&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=short_desc&type0-0-0=nowordssubstr&value0-0-0=crash+subscri+list+dupli+Summary+delet+folder
Reporter | ||
Updated•15 years ago
|
Target Milestone: Thunderbird 3.0b1 → ---
Comment 12•15 years ago
|
||
Finally escaped from the legal world long enough to dive back into this for a bit. This patch has import/export working, along with better feed->msf translation and more robust migration of old feed settings. Still a decent amount of work to be done, but I'm hoping to have something worth testing by the end of the week.
Attachment #358494 -
Attachment is obsolete: true
Comment 13•15 years ago
|
||
bug query supersedes comment 11 https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&product=MailNews+Core&product=Thunderbird&component=Feed+Reader&long_desc_type=anywordssubstr&long_desc=interval+check+updat+refresh++minute&resolution=---&bug_severity=major&bug_severity=normal&bug_severity=minor&chfieldto=Now&field0-0-0=short_desc&type0-0-0=nowordssubstr&value0-0-0=crash+subscri+list+dupli+Summary+delet+folder
Comment 14•15 years ago
|
||
Hmm, looks like a bitrot race compared to my goal of moving nsRssIncomingServer into JS. In any case, I'm most concerned about migration here, especially given the propensity with which feeds.rdf can become corrupted.
Updated•13 years ago
|
Assignee: jminta → nobody
Comment 15•13 years ago
|
||
(In reply to comment #14) > Hmm, looks like a bitrot race compared to my goal of moving nsRssIncomingServer > into JS. > > In any case, I'm most concerned about migration here, especially given the > propensity with which feeds.rdf can become corrupted. indeed. And, bug 471932 would still need to be addressed? another set of major bugs https://bugzilla.mozilla.org/buglist.cgi?negate0=1&query_format=advanced&field0-0-0=short_desc&bug_severity=major&type0-0-0=nowordssubstr&value0-0-0=crash%20subscri%20list%20dupli%20Summary%20delet%20folder&component=Feed%20Reader&resolution=---&product=MailNews%20Core&product=Thunderbird
Comment 17•9 years ago
|
||
Removing myslef on all the bugs I'm cced on. Please NI me if you need something on MailNews Core bugs from me.
Comment 18•8 years ago
|
||
Closing for these reasons: 1. Given the state of things with Tb and Moz, creating this dependency is bad strategy. No one in toolkit wants to own the feed code for Fx and will unlikely be responsive to Tb. 2. The toolkit code is one huge COMtaminated object, even according to its author[1], the great Mr. Atom himself. 3. The Tb feed parser is very simple, self contained, and just works for what Tb needs. 4. No one is going to do this work, and rightly so. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=525655#c7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•