450580 - Start Sunbird es_ES with clean profile -> error output

Status: VERIFIED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- use Sunbird version es_ES with a clean profile

RESULT:
=======

- output in error console at startup

Error: Se ignora la zona horaria 'Europe/Berlin' del sistema operativo. [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIStringBundle.formatStringFromName]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/ES/sunbird-0.9pre.es-ES.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/ES/sunbird-0.9pre.es-ES.win32/sunbird/js/calTimezoneService.js :: guessSystemTimezone :: line 724"  data: no]
Archivo de origen: file:///C:/Documents%20and%20Settings/at93795/My%20Documents/ES/sunbird-0.9pre.es-ES.win32/sunbird/components/calItemModule.js -> file:///C:/Documents%20and%20Settings/at93795/My%20Documents/ES/sunbird-0.9pre.es-ES.win32/sunbird/js/calTimezoneService.js
Línea: 736

EXPECTED RESULT:
================

- no output

REPRODUCIBLE:
=============

- always

Comment 1

[Daniel Boelzle [:dbo]]

Looks like TZFromOS (calendar.properties) isn't found; needs investigation.

Comment 2

[Stefan Sitter [:ssitter]]

Error is caused by a malformed calendar.properties file.

Replacing the line break in TZSeemsToMatchOS (line 134-135 in calendar.properties) by a "\n" character fixes the error.

http://bonsai-l10n.mozilla.org/cvsblame.cgi?file=l10n/es-ES/calendar/chrome/calendar/calendar.properties&rev=1.1.2.25&root=/l10n&mark=134-135#130

Comment 3

[RickieES aka Ricardo Palomares]

(In reply to comment #2)
> Error is caused by a malformed calendar.properties file.
> 
> Replacing the line break in TZSeemsToMatchOS (line 134-135 in
> calendar.properties) by a "\n" character fixes the error.
> 
> http://bonsai-l10n.mozilla.org/cvsblame.cgi?file=l10n/es-ES/calendar/chrome/calendar/calendar.properties&rev=1.1.2.25&root=/l10n&mark=134-135#130
> 


Sunbird 0.9pre comes from MOZILLA_1_8_BRANCH, where the file seems to be correct:

http://mxr.mozilla.org/l10n-mozilla1.8/source/es-ES/calendar/chrome/calendar/calendar.properties#134

Anyway, I'm going to test 0.9pre nightlies and check (I should have done it yesterday, but I couldn't, sorry).

Comment 4

[Stefan Sitter [:ssitter]]

(In reply to comment #3)
> Sunbird 0.9pre comes from MOZILLA_1_8_BRANCH, where the file seems to be
> correct:
> http://mxr.mozilla.org/l10n-mozilla1.8/source/es-ES/calendar/chrome/calendar/calendar.properties#134

Follow your on link and see that TZSeemsToMatchOS is wrapped on line 134 and 135.

Comment 5

[RickieES aka Ricardo Palomares]

(In reply to comment #4)
> (In reply to comment #3)
> > Sunbird 0.9pre comes from MOZILLA_1_8_BRANCH, where the file seems to be
> > correct:
> > http://mxr.mozilla.org/l10n-mozilla1.8/source/es-ES/calendar/chrome/calendar/calendar.properties#134
> 
> Follow your on link and see that TZSeemsToMatchOS is wrapped on line 134 and
> 135.


Err... I shouldn't do some things just after waking up. :-( Sorry.

I've just commit the fix (I've been looking but I haven't found a L10N freeze date for Calendar 0.9, so I've assumed I can still commit without requiring approval).

Comment 6

[RickieES aka Ricardo Palomares]

(In reply to comment #5)
> I've just commit the fix (I've been looking but I haven't found a L10N freeze
> date for Calendar 0.9, so I've assumed I can still commit without requiring
> approval).


Fixed and verified on Windows XP and Linux.