45059 - char coding toggling ineffective in a standalone message view window

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P3)

Description

[Gary Liu]

when opening a message (in its own window) with an attached japanese html, 
changing the character coding doesn't refresh the display at all. However, 
character coding change IS effective when you are viewing the message in the 
bottom pane.
Also, NS 6 no longer hangs when the character coding is toggled in a message 
window. 

observed with 2000-07-10-08 build
 
Steps to reproduce:
1. send yourself a japanese html and retrieve it.
2. double click on message to open it.
3. go to View|Character Coding and select a different coding.

observed result: nothing happens.
expected result: the message window should refresh

Comment 1

[nhottanscp]

Reassign to mscott.
This is about charset override for attachments opened in a browser window.
Scott, is there anything special for the browser window for an attachment?

Comment 2

[Scott MacGregor]

I'm confused about a comment in this bug report:

expected result: the message window should refresh

You mean the browser window don't you? I thought you were opening the html
attachment into a new browser window and then you are trying to refresh the
browser window?

Or are you still in a stand alone message window?

Comment 3

[Gary Liu]

the problem occurs in a stand alone message window, not a browser window.

Comment 4

[Scott MacGregor]

Just so I'm clear, cause this sounds a little strange. You are viewing a
message. It has an attachment. You click on the attachment icon and select the
Open radio button.

The .html attachment opens in a stand alone message window and not a browser
window? That sounds really odd!! for me, html files open in stand alone browser
windows when I try to open them not mail windows.

Or am is my confusion 'cause this has nothing to do with opening a message
attachment. But viewing the message in a stand alone message pane and trying to
chage the charset has no effecton the attachment?

Comment 5

[Katsuhiko Momoi]

Character Coding menu is totally disabled whether or
not there is an attachment to a message. The standalone
window's Character Coding menu is simply not functional.
A sizable number of people use standalone window particularly
when messages are long like when there are inline viewable 
attachments.

Comment 6

[Katsuhiko Momoi]

First, let's get the Character Coding menu work in
a standalone mail window. Then, we can look at cases of
attachments, e.g. an HTML attchament  which is encoded in
a different encoding than the main body and it has no
Meta-charset tag embedded in that document. In the view pane
window, you can change the Chracter Coding menu to view
such an inline attachment.

Comment 7

[Katsuhiko Momoi]

I changed the summary line to better reflect the nature of this
bug.

Comment 8

[nhottanscp]

A standalone window for a message and a browser for an opened attachment, 
for both cases charset override do not work.
I think this bug is for the attachment case.
Do we have one for a standalone window?
(But the summary just got changed while I was editing. Anyway, I think we need 
two bugs).

Comment 9

[Katsuhiko Momoi]

It says "when openign a *message* with ..." and so if we trust
that wording, this should be about the standalone window.
Let's file a new bug on the Browser vie window for attachments.

Comment 10

[Katsuhiko Momoi]

Naoki, I tried the Browser window for a Shift_JIS document
attchment with or without a meta tag in it and in both
cases, I can use the Character Coding menu to change the viewing
OK. Are there other types of cases?

Comment 11

[nhottanscp]

I can reproduce that with a message in my mbox. The message has a yahoo ja as an 
attachment. After I opened the attachment, in the browser window, I set a 
charset to EUC-jp using charset menu but it was not reloaded.

Comment 12

[nhottanscp]

I cannot reproduce the problem (open attachment) using win32 build ID 
2000071408.
Standalone message problem still exists.

Comment 13

[Scott MacGregor]

triaging.

Comment 14

[Katsuhiko Momoi]

Per i18n/mail triage meeting, this bug is marked
as [nsbeta3+]. A lot of use use standalone windows
to view messages and encoding menu change must be
effective in that window. 

Comment 15

[Scott MacGregor]

Attachment: proposed fix

Comment 16

[Scott MacGregor]

putterman can you review my fix? when bringing up the view menu from a stand
alone message pane, we got a JS error in view_init() saying that
IsThreadAndMessagePaneSplitterCollapsed.

In order to fix this, I had to make messageWindow.xul include
msgMail3PaneWindow.js (which is bogus but the view menu JS code demands that it
be there. Is there a better way?)

Comment 17

[scottputterman]

Attachment: another patch

Comment 18

[scottputterman]

Scott, 

Here's another patch that doesn't include msgMail3PaneWindow.js.  If it looks 
ok, I'll check it in.

Comment 19

[Scott MacGregor]

Looks good, feel free to check it in along with my fix to include shareglue.js

Comment 20

[scottputterman]

fix checked in.

Comment 21

[Katsuhiko Momoi]

gary, please verify this with the latest build. 
Things to check:

1. that any message which is showing OK should OK when it is opened in standalone window.
2. that any message which has no MIME info (test file, noMIME) should be be OK in the 
   main window if the view default is set correctly, and then should show OK in the standalone. 
3. that any message which has incorrect MIME info can be corrected in the main view window,
   should show OK in the standalone window inheriting the correction.

If correction in the main window is not inherited, then file a bug.

4. If for any reason, display is broken in the standalone window, then it should be correctable with 
   View Character Coding menu. Exception might be a header.
5. Attachment should be correctable if not showing correctly in the standalone window. 

There are perhaps more. But the principle is that if something can be displayed in the main
view window, then it should be equally viewable in the standalone window. Another
principle is that the standalone should inherit any corrections already made in the main
view window.

Comment 22

[Katsuhiko Momoi]

QA contcat to guangyan.

Comment 23

[Gary Liu]

in the 08-16-08M18 build, this problem has been fixed: changing view charset 
setting in the standalone window is actually functional.  However, bug 49230 
has been filed because standalone message window does NOT inherit changes made 
to the main window settings.