gmail (v2) gets stuck loading with session store enabled

RESOLVED FIXED

Status

()

Firefox
Session Restore
RESOLVED FIXED
9 years ago
3 years ago

People

(Reporter: u88484, Assigned: Simon Bünzli)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
I always have session store enabled and gmail loaded so when I closed Firefox via the X button in the top right and reopen Firefox, 99% of the time gmail won't load again and gets stuck on the page with the progress bar trying to load the inbox.  I've seen this for months on both XP and Vista.  This is probably related to AJAX.

1) Have gmail (v2) open and session store enabled
2) Close firefox
3) Restart and 99% of the time gmail doesn't load completly and gets stuck loading on the page that has the progressbar.
(Assignee)

Comment 1

9 years ago
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/20080814041610

This reliably WORKSFORME.
* Does this happen on a clean profile as well?
* Does this happen from your work/home PC as well (ruling out connection issues)?
* Do you get any errors in the Error Console?
Whiteboard: [worksforme?]

Comment 2

9 years ago
This happens to me as well. I saw that first time restarting the tab it loads, but other times, it won't. No errors from Error Console.
(WinXP, Firefox 3.0.1)
(Reporter)

Comment 3

9 years ago
(In reply to comment #1)
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre)
> Gecko/20080814041610
> This reliably WORKSFORME.
> * Does this happen on a clean profile as well? yep and also with 3.0.1

> * Does this happen from your work/home PC as well (ruling out connection
> issues)?

Can't use it at work but I have multiple profile at home on different versions of firefox/minefield

> * Do you get any errors in the Error Console?
Not sure, will check out later

Comment 4

9 years ago
Problem occurs for me as well. Refresh is always needed to complete loading mail.
(Assignee)

Comment 5

9 years ago
Please don't just add "me too" but provide further information such as:
* What Firefox version you're using (see Help -> About Mozilla Firefox).
* Whether this also happens when disabling all extensions (in Safe Mode).

Bonus points for:
* Whether it also happens when just closing the Gmail tab and then reopening it through History -> Recently Closed Tabs.
* What language Gmail is currently set to.
* Whether you use any of the new Gmail beta features.

Comment 6

9 years ago
So, I looked into it a bit more, and..

- Yes, it happens when reopening through history as well
- Yes, it happens in Safe mode too
- English language is set
- Beta features - I never turned anything on, so.. most possibly, no..

Also I noticed that refreshing the stuck panel doesn't help, you need to type the URL again.

(firefox 3.0.1, winxp)
(Reporter)

Comment 7

9 years ago
(In reply to comment #6)
> So, I looked into it a bit more, and..
> 
> - Yes, it happens when reopening through history as well
> - Yes, it happens in Safe mode too
> - English language is set
> - Beta features - I never turned anything on, so.. most possibly, no..
> 
> Also I noticed that refreshing the stuck panel doesn't help, you need to type
> the URL again.
> 
> (firefox 3.0.1, winxp)
> 
Exactly the same thing here except with both 3.0.1, 3.0 and trunk nightlies for past couple of months.
(Assignee)

Comment 8

9 years ago
Alright, I've somehow managed to occasionally hit this as well. Don't see what could trigger it, though. Next guess: Does it happen on http:// only or when enforcing a secure connection through https:// (see the Gmail preferences) as well? So far, I've only seen it on non-secure connections.
Whiteboard: [worksforme?]
(Reporter)

Comment 9

9 years ago
I always use the secure connection https://
(Assignee)

Updated

9 years ago
Component: General → Session Restore
QA Contact: general → session.restore
Hardware: PC → All
(Assignee)

Comment 10

9 years ago
Created attachment 333916 [details] [diff] [review]
don't restore wyciwyg URLs

After some more debugging, I think I've found the issue: Gmail has us explictly cache several script-only documents which are loaded in (i)frames. Trying to restore these breaks Gmail in the way reported by this bug.

As these are wyciwyg URLs, there would be no point in restoring them after a crash, anyway (which BTW currently also causes bug 424689), so we should just ignore them (meaning that we have to refrain from loading anything in the frameset so that the default URLs aren't overwritten).

If you're affected by this issue, please try to manually apply this patch to the file nsSessionStore.js in Firefox's components directory and make sure that this fixes the issue for you.
Attachment #333916 - Flags: review?(gavin.sharp)
(Assignee)

Updated

9 years ago
Blocks: 424689
(Reporter)

Comment 11

9 years ago
(In reply to comment #10)
> If you're affected by this issue, please try to manually apply this patch to
> the file nsSessionStore.js in Firefox's components directory and make sure that
> this fixes the issue for you.
> 
Session store isn't working after adding those lines.  I keep getting: 
Error: illegal character
Source File: file:///C:/Junk/firefox/components/nsSessionStore.js
Line: 1, Column: 1
Source Code:
/* ***** BEGIN LICENSE BLOCK ***** 

I know it is not due to adding those lines of code but I can't figure out why it seems to be saving those characters weirdly even though they look fine in notepad.  Any suggestions?
Probably a character encoding issue
(Reporter)

Comment 13

9 years ago
Works with wordpad, weird.  I've closed Firefox about 20 times, reopened it and haven't seen the issue yet.
(Assignee)

Updated

9 years ago
Attachment #333916 - Flags: review?(dietrich)
Comment on attachment 333916 [details] [diff] [review]
don't restore wyciwyg URLs

r=me, thanks
Attachment #333916 - Flags: review?(dietrich) → review+
(Assignee)

Updated

9 years ago
Assignee: nobody → zeniko
Keywords: checkin-needed
Attachment #333916 - Flags: review?(gavin.sharp) → review+

Comment 15

9 years ago
pushed to mozilla-central: https://hg.mozilla.org/mozilla-central/index.cgi/rev/78b1363d2fd4
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
(Reporter)

Updated

9 years ago
Flags: wanted1.9.0.x?
(Reporter)

Updated

9 years ago
Attachment #333916 - Flags: approval1.9.0.3?
Comment on attachment 333916 [details] [diff] [review]
don't restore wyciwyg URLs

We're no longer taking "nice to haves" on the branch.
Attachment #333916 - Flags: approval1.9.0.4? → approval1.9.0.4-
(Assignee)

Updated

9 years ago
Attachment #333916 - Flags: approval1.9.0.4- → approval1.9.0.4?
(Assignee)

Comment 17

9 years ago
Comment on attachment 333916 [details] [diff] [review]
don't restore wyciwyg URLs

We need this for Firefox 2 as well.
Attachment #333916 - Flags: approval1.8.1.18?
re-requesting approval in light of bug 459906
Flags: wanted1.9.0.x? → wanted1.9.0.x+
Blocks: 459906
(Assignee)

Updated

9 years ago
No longer blocks: 459906
(Assignee)

Updated

9 years ago
Attachment #333916 - Flags: approval1.9.0.4?
Attachment #333916 - Flags: approval1.8.1.18?
(Assignee)

Comment 19

9 years ago
Comment on attachment 333916 [details] [diff] [review]
don't restore wyciwyg URLs

Doesn't help for bug 459906, after all.
Flags: wanted1.9.0.x+

Updated

9 years ago
Depends on: 496061
Depends on: 1158855
You need to log in before you can comment on or make changes to this bug.