Closed Bug 450651 Opened 14 years ago Closed 14 years ago

Dependencies don't work in media/libtheora/lib

Categories

(Firefox Build System :: General, defect)

x86
All
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(1 file, 1 obsolete file)

Our "manual" dependency generation assumes that all object files get created in the same objdir. Actually that's not quite true. Originally rules.mk used $(<D) to strip off the path of the source file. This didn't actually work since mkdepend is a Windows binary and therefore gets passed "Windows" paths but $(<D) is a cygwin/msys path. It was then changed to strip off $(srcdir) and this version would have been compatible with the theora Makefile. However it wasn't compatible with the uriloader/exthandler Makefile and rules.mk was eventually switched to strip paths using a wildcard.

The media/theora/lib Makefile needs to find its source files in the same way that the uriloader/exthandler Makefile so that its dependencies are correct.
Attached patch Proposed patch (obsolete) — Splinter Review
Use VPATH instead of manually specifying subfolders
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #333833 - Flags: review?(ted.mielczarek)
Attachment #333833 - Flags: review?(chris.double)
Comment on attachment 333833 [details] [diff] [review]
Proposed patch

+VPATH		:= $(srcdir) $(srcdir)/dec
+ 

Any reason you didn't just put this in the VPATH declaration at the beginning of the file?
Attachment #333833 - Flags: review?(ted.mielczarek) → review+
I tried to base the patch on uriloader/exthandler/Makefile.in but I admit I overlooked the subtlety of that change.
Attachment #333833 - Attachment is obsolete: true
Attachment #334491 - Flags: review+
Attachment #333833 - Flags: review?(chris.double)
Pushed changeset 8c2ce1c8be08 to mozilla-central (without trailing spaces).
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.