Closed
Bug 450666
Opened 17 years ago
Closed 17 years ago
Increase intervals for long-running tests
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rdoherty, Assigned: anodelman)
References
Details
Attachments
(2 files)
|
936 bytes,
patch
|
bhearsum
:
review+
|
Details | Diff | Splinter Review |
|
916 bytes,
patch
|
bhearsum
:
review+
anodelman
:
checked-in+
|
Details | Diff | Splinter Review |
In order to reduce the amount of data the graph server needs to store/retrieve, we need to increase the interval for long running tests.
First idea is tests that run for more than 10 minutes can have their intervals increased to once every 10 seconds?
| Assignee | ||
Comment 1•17 years ago
|
||
I'm running some tests on talos stage to only poll for memory/cpu information every 20 seconds. I'll compare the test results taken with different granularities to determine if we are losing any valuable information by polling less.
Priority: -- → P2
| Assignee | ||
Comment 2•17 years ago
|
||
I'm not seeing much difference in the numbers by sampling less frequently. I think that this is pretty low risk and will reduce the amount of data sent to the graph server by a given talos cycle pretty dramatically.
Attachment #336106 -
Flags: review?(rdoherty)
| Reporter | ||
Comment 3•17 years ago
|
||
Comment on attachment 336106 [details] [diff] [review]
[Checked in]sample memory/cpu only every 20 seconds instead of every second
I'm not sure I should be reviewing this patch. I've never touched or seen this code before.
| Assignee | ||
Updated•17 years ago
|
Attachment #336106 -
Flags: review?(rdoherty) → review?(bhearsum)
Updated•17 years ago
|
Attachment #336106 -
Flags: review?(bhearsum) → review+
| Assignee | ||
Comment 4•17 years ago
|
||
Comment on attachment 336106 [details] [diff] [review]
[Checked in]sample memory/cpu only every 20 seconds instead of every second
/cvsroot/mozilla/testing/performance/talos/sample.config,v <-- sample.config
new revision: 1.18; previous revision: 1.17
done
Attachment #336106 -
Attachment description: sample memory/cpu only every 20 seconds instead of every second → [Checked in]sample memory/cpu only every 20 seconds instead of every second
| Assignee | ||
Comment 5•17 years ago
|
||
Will need to keep an eye on this in case it radically alters the numbers collected.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 6•17 years ago
|
||
Looks like this got accidentally switched back to '1' at some point...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
| Assignee | ||
Comment 7•17 years ago
|
||
Must have happened with the patch that ensures that we run talos tests in a specific order. Need to be more careful with this main config file, since it is run everywhere.
Attachment #353343 -
Flags: review?(bhearsum)
Comment 8•17 years ago
|
||
Comment on attachment 353343 [details] [diff] [review]
[Checked in]sample memory/cpu only every 20 seconds instead of every second (once again)
Boy, it's confusing to have dashes as valid starts of lines.
Looks fine though.
Attachment #353343 -
Flags: review?(bhearsum) → review+
| Assignee | ||
Comment 9•17 years ago
|
||
Comment on attachment 353343 [details] [diff] [review]
[Checked in]sample memory/cpu only every 20 seconds instead of every second (once again)
Checking in sample.config;
/cvsroot/mozilla/testing/performance/talos/sample.config,v <-- sample.config
new revision: 1.22; previous revision: 1.21
done
Attachment #353343 -
Attachment description: sample memory/cpu only every 20 seconds instead of every second (once again) → [Checked in]sample memory/cpu only every 20 seconds instead of every second (once again)
Attachment #353343 -
Flags: checked‑in+
| Assignee | ||
Updated•17 years ago
|
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•