Mark as read still can't be disabled when "immediately on display" is chosen

RESOLVED FIXED in mozilla1.9.1a2


10 years ago
10 years ago


(Reporter: christopher.rodgers, Assigned: mkmelin)



Firefox Tracking Flags

(Not tracked)




(1 attachment)



10 years ago
User-Agent:       Mozilla/4.0 (compatible; MSIE 7.0; Windows NT 6.0; WOW64; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.0.04506; InfoPath.2; .NET CLR 1.1.4322; .NET CLR 3.5.21022)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1a2pre) Gecko/20080814031842 Shredder/3.0b1pre

The option to not automatically mark messages as "read" on an IMAP account does not work.

This bug causes data loss (of the "read" flags).

Reproducible: Always

Steps to Reproduce:
1. Delete profile folder.
2. Start thunderbird.
3. Add IMAP account.
4. Choose Tools...Options...Advanced
5. Disable "Automatically mark messages as read"
6. Click OK
7. Choose messages from the IMAP account - they will incorrectly be marked as read.

The screenshot and network capture at show this.

The problem seems to be that Thunderbird is sending an IMAP FETCH command when it should send a PEEK.

My previous patch to bug 297534 tackled that problem.
IMAP problem.

And, FWIW, you mean it's sending a FETCH (BODY[]) where you want a FETCH (BODY.PEEK[]).
Assignee: nobody → bienvenu
Component: Mail Window Front End → Networking: IMAP
Product: Thunderbird → Core
QA Contact: front-end → networking.imap
Version: unspecified → Trunk

Comment 2

10 years ago
Ah yes, I see the problem now.
Assignee: bienvenu → mkmelin+mozilla
OS: Windows Vista → All
Hardware: PC → All
Summary: Mark as read feature still broken (i.e. bug 297534 not resolved) → Mark as read still can't be disabled when "immediately on display" is chosen


10 years ago
Ever confirmed: true

Comment 3

10 years ago
Created attachment 333961 [details] [diff] [review]
proposed fix

Mistake in the peek vs. fetch logic. If auto-marking is off, should always peek.
Attachment #333961 - Flags: superreview?(bienvenu)
Attachment #333961 - Flags: review?(bienvenu)

Comment 4

10 years ago
Comment on attachment 333961 [details] [diff] [review]
proposed fix

that's right, thx, Magnus.
Attachment #333961 - Flags: superreview?(bienvenu)
Attachment #333961 - Flags: superreview+
Attachment #333961 - Flags: review?(bienvenu)
Attachment #333961 - Flags: review+

Comment 5

10 years ago
changeset:   110:e7459764ea53

Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1


10 years ago
Target Milestone: mozilla1.9.1 → mozilla1.9.1a2
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.