Closed Bug 450782 Opened 12 years ago Closed 12 years ago

overpan events are hard to trigger with kinetic scrolling enabled

Categories

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Other
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
fennec1.0m7

People

(Reporter: blassey, Assigned: blassey)

Details

(Keywords: mobile)

Attachments

(1 file)

Comment on attachment 333980 [details] [diff] [review]
skips kinetic if fireOverpan is set, also handles theover pan if url bar is showing

>           mouseup: function seh_mouseup(aEvent) {
>+            var skipKinetic = false;
>             if (aEvent.button == 0 && this.deckbrowser.dragData.dragging) {
>-              this.deckbrowser.dragData.dragging = false;
>+              if (this.deckbrowser._fireOverpan) {
>+                this.deckbrowser._endPan();
>+                skipKinetic = true;
>+              } else
>+                this.deckbrowser.dragData.dragging = false;

Add { } around the "else" (if the "if" has it, the "else" should have it)

r+ with that change
Attachment #333980 - Flags: review?(mark.finkle) → review+
Assignee: nobody → blassey
Target Milestone: --- → Fennec M7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: General → Panning/Zooming
Referring to the actual state of the application I can mark this as VERIFIED FIXED on:

Build Id: Mozilla/5.0 (Maemo; Linux armv7l; rv:6.0a1) Gecko/20110510
Firefox/6.0a1 Fennec/6.0a1

Device: Nokia N900 (Maemo GTK)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.