450808 - sunbird da and it locales have corrupted install.rdf

Status: RESOLVED FIXED

(Mozilla Localizations :: da / Danish, defect)

Description

[Saïvann Carignan]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; fr; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1
Build Identifier: 0.8

da.xpi and it.xpi locale extensions for sunbird 0.8 are refused by sunbird, sunbird complains about a corrupted install.rdf file.

This is indeed the case. I am the packager of the sunbird locales for ubuntu and There is 4 line breaks which should not bee in the install.rdf files of these two locales. Removing these break lines fixes the xpi.

ftp://releases.mozilla.org/pub/mozilla.org/calendar/sunbird/releases/0.8/langpacks/da.xpi
ftp://releases.mozilla.org/pub/mozilla.org/calendar/sunbird/releases/0.8/langpacks/it.xpi

I attach patches to this bug report so you can fix this problem.

Reproducible: Always

Steps to Reproduce:
1. Have sunbird 0.8
2. Try to install it or da language pack through the extension manager.
Actual Results:  
It fails, sunbird shows a error msg

Expected Results:  
The locale should install properly and simply works.

Comment 1

[Saïvann Carignan]

Attachment: Patch to fix da.xpi

Comment 2

[Saïvann Carignan]

Attachment: Patch to fix it.xpi

Comment 3

[Alexander Sack]

confirming bug.

Comment 4

[Jesper Kristensen]

I can confirm the bug for the danish language pack at http://releases.mozilla.org/pub/mozilla.org/calendar/sunbird/releases/0.8/langpacks/da.xpi

I don't know what is causing the problem. We cannot use the patch, because it is not a patch to the source files, but to the finished XPI.

Comment 5

[Vlado Valastiak [:wladow]]

Maybe it was caused by Bug 409956. We had a similar problem with langpacks for SeaMonkey and it was caused by this bug.

Comment 6

[Iacopo Benesperi [:iacchi]]

I'm with a gprs connection now, so it's a mess to download a sunbird package to test the langpack. Anyway, since the rdf files are the same in Italian and Danish, I believe the problem it's the same and since the proposed patch for Italian is the same than the one for Danish, and since for the Danish locale it worked, I believe I can accept the patch for the Italian locale.
If you want me to verify it, you'll have to wait the next week as a minimum.

Comment 7

[Saïvann Carignan]

Iacopo Benesperi : Thanks for this. Yes, both it and da locales have the same problem in their install.rdf files. My patch only fixes the 4 line break which should not be there, and which are not in any other xpi language pack anyway.

Comment 8

[Jesper Kristensen]

The problem seems to be that da/calendar/defines.inc and it/calendar/defines.inc uses Windows style line endings instead of Unix style line endings on the mozilla1.8 branch. (This seems to be fixed on trunk for the Italian file, but I guess Sunbird 0.9 is still going to be released from the 1.8 branch.)

Comment 9

[Simon Paquet [:sipaq]]

(In reply to comment #8)
> The problem seems to be that da/calendar/defines.inc and
> it/calendar/defines.inc uses Windows style line endings instead of Unix style
> line endings on the mozilla1.8 branch. (This seems to be fixed on trunk for the
> Italian file, but I guess Sunbird 0.9 is still going to be released from the
> 1.8 branch.)

That's correct. The Windows/DOS line endings seem to be the culprit and 0.9 will be released from the 1.8 branch.

I just went through both the Italian and the Danish Calendar localization files. For Italian only the files in the l10n/it/calendar root directory have DOS line endings, but for Danish many more files (probably a third of all files) have DOS line endings.

Guys, I would appreciate it, if both of you (Iacopo and Jesper) could go through your files and fix the DOS line endings issue, because that will save you lots of trouble later on.

Comment 10

[Jesper Kristensen]

(In reply to comment #9)
> Guys, I would appreciate it, if both of you (Iacopo and Jesper) could go
> through your files and fix the DOS line endings issue, because that will save
> you lots of trouble later on.

Søren should do that for Danish. I don't have CVS access.

Comment 11

[Iacopo Benesperi [:iacchi]]

I've changed the four files in the calendar root directory, and I've done the checkin.
I don't know for Danish, but I use Mozilla Translator for the translation and the problem is with the software. I've tried to delete the four files and make MT recreate them, and it recreate them with DOS line ending.
I'll write to Ricardo for that.

Comment 12

[Søren Munk Skrøder (extended hiatus)]

(In reply to comment #9)
> 
> That's correct. The Windows/DOS line endings seem to be the culprit and 0.9
> will be released from the 1.8 branch.
> 
> I just went through both the Italian and the Danish Calendar localization
> files. For Italian only the files in the l10n/it/calendar root directory have
> DOS line endings, but for Danish many more files (probably a third of all
> files) have DOS line endings.
> 
> Guys, I would appreciate it, if both of you (Iacopo and Jesper) could go
> through your files and fix the DOS line endings issue, because that will save
> you lots of trouble later on.
> 

Simon - can you point me to a tool (or Linux shell command) that can discover the files containing DOS style endings ... 
I tried a 
  grep -ir "\r\n" . 
but got nothing

I unfortunately can't fix this unless I know how to find the failing files...

Comment 13

[Simon Paquet [:sipaq]]

I would just open the various (41) files in vim. 

If you have this in vim:
:set fileformats=dos,unix

Then vim will recognize the various line endings. When you load a DOS file in a Unix vim, vim will mark it with "[dos]" in the status line. Just do "set ff=unix", and it will write the file with the right endings.

You could also use the dos2unix command. 
See http://linux.about.com/od/commands/l/blcmdl1_dos2uni.htm

I'll to prepare a full list of files with DOS line endings for you.

Comment 14

[Simon Paquet [:sipaq]]

(In reply to comment #12)
> I unfortunately can't fix this unless I know how to find the failing files...

Søren, you will need to fix these files on the cvs trunk and the 1.8 branch:

- da/other-licenses/branding/sunbird/brand.dtd
- da/other-licenses/branding/sunbird/brand.properties
- da/calendar/defines.inc
- da/calendar/README.tx
- da/calendar/extra-jar.mn
- da/calendar/sunbird-l10n.js
- da/calendar/installer/mui.properties
- da/calendar/installer/override.properties
- da/calendar/installer/custom.properties
- da/calendar/chrome/branding/brand.dtd
- da/calendar/chrome/branding/brand.properties
- da/calendar/chrome/calendar/aboutDialog.dtd
- da/calendar/chrome/calendar/aboutDialog.dtd
- da/calendar/chrome/calendar/calendarCreation.dtd
- da/calendar/chrome/calendar/categories.properties
- da/calendar/chrome/calendar/preferences/categories.dtd
- da/calendar/chrome/calendar/preferences/connection.dtd
- da/calendar/chrome/calendar/preferences/preferences.dtd

Hope that helps.

Comment 15

[Søren Munk Skrøder (extended hiatus)]

Simon: Thanks for the list - I'll look into it tomorrow...

Can I ask what tool / command you used to find these files - i assume you didn't go through all our files by hand ;-D

Btw - Do I need to fix this on trunk - I thought that post-0.9 in mercurial repo would be based on the 1.8 branch anyways...
(seems to have seen a moz.dev.l10n post about not needing to keep the trunk up to date due to this fact)

Comment 16

[Søren Munk Skrøder (extended hiatus)]

aha ... found the command ... 
On debian-like distros (e.g. Ubuntu) one can issue:
  egrep -irl $'\r\n' . 

to recursively list all files that have DOS file endings...

Comment 17

[Simon Paquet [:sipaq]]

(In reply to comment #15)
> Can I ask what tool / command you used to find these files - i assume you
> didn't go through all our files by hand ;-D

Unfortunately, I did :)

> Btw - Do I need to fix this on trunk - I thought that post-0.9 in mercurial
> repo would be based on the 1.8 branch anyways...

You're right, my fault. Please fix this on the branch and on mercurial.

Comment 18

[Stefan Sitter [:ssitter]]

Could someone give a status update? Is this already fixed for Sunbird 0.9 RC1? If not please mark it blocking Bug 450589.

Comment 19

[Saïvann Carignan]

Marked as blocking bug 450589, the problem can still be reproduced for da locale (it locale does not have this problem anymore).

Comment 20

[Philipp Kewisch [:Fallen][📱📆]]

Other ways to find out:

grep -r "(Ctrl+V)(Ctrl+M)" *

Other ways to translate:

recode ibmpc..latin1 <files>

We need to get this fixed fast, so we can release! This needs to be fixed at least on SUNBIRD_0_9_BRANCH, but ideally also on HEAD and MOZILLA_1_8_BRANCH. mercurial is not needed atm.

Comment 21

[Philipp Kewisch [:Fallen][📱📆]]

sorry, the recode command should of course use utf8

Comment 22

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Patch to fix core da issues.

This patch fixes newlines on all files I could find and should also fix the install.rdf error since defines.inc is fixed.

It would be good to have this checked in asap!

Comment 23

[Jesper Kristensen]

That patch looks fine to me. Could you check it in?

Comment 24

[Philipp Kewisch [:Fallen][📱📆]]

I personally don't have l10n access. 

ause, could you check this in?

Comment 25

[ause]

committed. three files changed since patch creation. fixed thos lineends manually.

Comment 26

[Philipp Kewisch [:Fallen][📱📆]]

marking FIXED, please reopen if problems remain. Also, it would be nice if the changes could also be applied to MOZILLA_1_8_BRANCH at some point, just for reference.

-> FIXED