c++ style comment in js/src/jsemit.c

VERIFIED FIXED

Status

()

Core
JavaScript Engine
--
minor
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: ul, Assigned: Brian Crowder)

Tracking

({verified1.8.1.17})

1.8 Branch
verified1.8.1.17
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
User-Agent:       Mozilla/5.0 (X11; U; AIX 5.1; en-US; rv:1.8.1.16) Gecko/20080806 Firefox/2.0.0.16
Build Identifier: MOZILLA_1_8_BRANCH

build bustage due to c++ style comment in c source file

Reproducible: Always

Steps to Reproduce:
1. build with a C89 ANSI C compiler

Actual Results:  
comilation error due to illegal C code

Expected Results:  
successful compilation

Trunk requires C99 compiler, but MOZILLA_1_8_BRANCH still supports C89 ANSI compilers.
Found this with  VisualAge C++ 5.0.2.9 on AIX 4.3.3 (which has no C99!)
(Reporter)

Comment 1

9 years ago
Created attachment 334078 [details] [diff] [review]
replaces c++ with c style comment only

This trivial patch makes jsemit.c compile on pre-C99 C compilers on branch MOZILLA_1_8_BRANCH
Attachment #334078 - Flags: review?
(Reporter)

Updated

9 years ago
Attachment #334078 - Flags: review? → review?(shaver)
(Reporter)

Updated

9 years ago
Version: unspecified → 1.8 Branch
Comment on attachment 334078 [details] [diff] [review]
replaces c++ with c style comment only

r=shaver, sure.
Attachment #334078 - Flags: review?(shaver) → review+
(Reporter)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

9 years ago
As trivial as it is, I don't think this can land w/o branch approval.  (correct me if I'm wrong, shaver)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: checkin-needed
(Assignee)

Comment 4

9 years ago
Comment on attachment 334078 [details] [diff] [review]
replaces c++ with c style comment only

Trivial.
Attachment #334078 - Flags: approval1.9.0.2?
(Assignee)

Comment 5

9 years ago
Comment on attachment 334078 [details] [diff] [review]
replaces c++ with c style comment only

Woops, wrong branch.
Attachment #334078 - Flags: approval1.9.0.2? → approval1.8.1.17?
-> crowder for check-in
Assignee: general → crowder
Comment on attachment 334078 [details] [diff] [review]
replaces c++ with c style comment only

Approved for 1.8.1.17, a=dveditz for release-drivers.
Attachment #334078 - Flags: approval1.8.1.17? → approval1.8.1.17+
(Assignee)

Updated

9 years ago
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Adding keyword...
Keywords: fixed1.8.1.17
(Assignee)

Comment 9

9 years ago
Sorry, didn't think the keyword was necessary; as this is 1.8.1.17-only.
Sadly, we do, since the only way to track branch bugs is by keyword. Bugzilla sucks. :(
Verified FIXED using

http://mxr.mozilla.org/mozilla1.8/source/js/src/jsemit.c#608:

608             /* FALL THROUGH */

Replacing fixed1.8.1.17 with verified1.8.1.17, and marked as Verified FIXED.
Status: RESOLVED → VERIFIED
Keywords: fixed1.8.1.17 → verified1.8.1.17

Updated

9 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.