Closed
Bug 450920
Opened 17 years ago
Closed 16 years ago
4 new warnings in <nsXMLHttpRequest.cpp>
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla1.9.1b2
People
(Reporter: sgautherie, Assigned: smaug)
References
Details
Attachments
(1 file)
723 bytes,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080817015046 Minefield/3.1a2pre] (home, optim default) (W2Ksp4)
This would seem to have appeared in the last few days:
{{
.../content/base/src/nsXMLHttpRequest.cpp(1210) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(1210) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(2454) : warning C4244: 'initializing' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(2458) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
}}
Reporter | ||
Comment 1•17 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080817024436 Minefield/3.1a2pre] (home, debug) (W2Ksp4)
(Same in debug build.)
Assignee | ||
Comment 2•17 years ago
|
||
ProgressEvents will be changed to use PRUint64 http://www.w3.org/2008/webapps/track/issues/37, these warnings should go away then.
Reporter | ||
Comment 3•16 years ago
|
||
Before bug 460751 checkin, 5 warnings:
{
.../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(3155) : warning C4244: 'initializing' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(3159) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(3164) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
}
After it, 3 warnings remain:
{
.../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
.../content/base/src/nsXMLHttpRequest.cpp(3166) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data
}
Reporter | ||
Comment 4•16 years ago
|
||
(In reply to comment #3)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081019 SeaMonkey/2.0a2pre] (home, optim default) (W2Ksp4)
Reporter | ||
Comment 5•16 years ago
|
||
(In reply to comment #4)
Same with
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081019 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)
Assignee | ||
Comment 6•16 years ago
|
||
I don't get those warnings on linux.
I guess s/0/PRUint64(0)/ is needed? Serge, would that fix the warnings?
Assignee | ||
Comment 7•16 years ago
|
||
Ah, hmm, I need to change mLoadTotal to PRUint64
Assignee | ||
Comment 8•16 years ago
|
||
Serge, could you perhaps test what is causing those warnings on line 1693.
The line 3166 problem should be fixed if mLoadTotal is changed to be
PRUint64.
I checked few tbox logs, and there I saw only warning about line 3166
Assignee | ||
Comment 9•16 years ago
|
||
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #344454 -
Flags: superreview?(jonas)
Attachment #344454 -
Flags: review?(jonas)
Attachment #344454 -
Flags: superreview?(jonas)
Attachment #344454 -
Flags: superreview+
Attachment #344454 -
Flags: review?(jonas)
Attachment #344454 -
Flags: review+
Reporter | ||
Comment 10•16 years ago
|
||
(In reply to comment #8)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081022 SeaMonkey/2.0a2pre] (home, debug default) (W2Ksp4)
> Serge, could you perhaps test what is causing those warnings on line 1693.
Odd, I don't get them anymore :-|
> The line 3166 problem should be fixed if mLoadTotal is changed to be
> PRUint64.
I confirm that this patch fixes this warning.
Assignee | ||
Updated•16 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 11•16 years ago
|
||
V.Fixed, per previous comment.
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.9.1b2
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•