Closed Bug 450920 Opened 17 years ago Closed 16 years ago

4 new warnings in <nsXMLHttpRequest.cpp>

Categories

(Core :: DOM: Core & HTML, defect)

x86
Windows 2000
defect
Not set
minor

Tracking

()

VERIFIED FIXED
mozilla1.9.1b2

People

(Reporter: sgautherie, Assigned: smaug)

References

Details

Attachments

(1 file)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080817015046 Minefield/3.1a2pre] (home, optim default) (W2Ksp4) This would seem to have appeared in the last few days: {{ .../content/base/src/nsXMLHttpRequest.cpp(1210) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(1210) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(2454) : warning C4244: 'initializing' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(2458) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data }}
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080817024436 Minefield/3.1a2pre] (home, debug) (W2Ksp4) (Same in debug build.)
ProgressEvents will be changed to use PRUint64 http://www.w3.org/2008/webapps/track/issues/37, these warnings should go away then.
Depends on: 460751
Before bug 460751 checkin, 5 warnings: { .../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(3155) : warning C4244: 'initializing' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(3159) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(3164) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data } After it, 3 warnings remain: { .../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(1693) : warning C4244: 'argument' : conversion from 'PRUint64' to 'PRUint32', possible loss of data .../content/base/src/nsXMLHttpRequest.cpp(3166) : warning C4244: '=' : conversion from 'PRUint64' to 'PRUint32', possible loss of data }
(In reply to comment #3) [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081019 SeaMonkey/2.0a2pre] (home, optim default) (W2Ksp4)
(In reply to comment #4) Same with [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081019 Minefield/3.1b2pre] (home, optim default) (W2Ksp4)
I don't get those warnings on linux. I guess s/0/PRUint64(0)/ is needed? Serge, would that fix the warnings?
Ah, hmm, I need to change mLoadTotal to PRUint64
Serge, could you perhaps test what is causing those warnings on line 1693. The line 3166 problem should be fixed if mLoadTotal is changed to be PRUint64. I checked few tbox logs, and there I saw only warning about line 3166
Assignee: nobody → Olli.Pettay
Status: NEW → ASSIGNED
Attachment #344454 - Flags: superreview?(jonas)
Attachment #344454 - Flags: review?(jonas)
Attachment #344454 - Flags: superreview?(jonas)
Attachment #344454 - Flags: superreview+
Attachment #344454 - Flags: review?(jonas)
Attachment #344454 - Flags: review+
(In reply to comment #8) [Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081022 SeaMonkey/2.0a2pre] (home, debug default) (W2Ksp4) > Serge, could you perhaps test what is causing those warnings on line 1693. Odd, I don't get them anymore :-| > The line 3166 problem should be fixed if mLoadTotal is changed to be > PRUint64. I confirm that this patch fixes this warning.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
V.Fixed, per previous comment.
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla1.9.1b2
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: