450931 - Google search plugins localization

Status: RESOLVED WORKSFORME

(Firefox :: Search, defect)

Description

[Sebastien Marinier]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; fr; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; fr; rv:1.9.0.1) Gecko/2008070206 Firefox/3.0.1

The Google search plugins is always in english by default. It should used the localization setup from Firefox.

Reproducible: Always

Steps to Reproduce:
1. Type a search in the search box (top right)
2. Results are in google.com
3.


Expected Results:  
Localized results (as the Home Page from Firefox)

In the google.xml (searchplugins folder), the suggestions use the correct localization : "hl={moz:locale}".

So i add 
<Param name="hl" value="{moz:locale}"/>

in google.xml, and it works (at least in french). I suggest to update google.xml with this modification.

Comment 1

[Francesco Lodolo [:flod]]

Strange... As far as I know, Google search plugin is the same for all locales: if I search something with that searchplugin, results are displayed from google.it (I'm using the Italian version of Firefox), not from google.com

If you create a new profile the behaviour is the same?

Comment 2

[Sebastien Marinier]

In fact, this is all handled by Google cookies. If you click once (what i've done) on "Google.com in English", all yours calls to google.com will be handled in english, including the search from Firefox (wich is based on google.com).
The parameter rls=org.mozilla:fr:official doesn't affect the google localization.

As the suggestions Url use the correct "hl", i maintain my suggestion to localize the search.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Stas, can you enlighten us?

Comment 4

[Axel Hecht [:Pike]]

The suggest hl selection is to actually get a specific corpus for suggest.

We're not passing an hl for search because that's what google considers to be the right thing for their search experience.

I guess it can't hurt to occasionally check back on whether we're still making the right call here. Kev?

In general, though, I think that the default locale selection plus cookie behaviour is gonna be right for most of our users, and I don't know if there's a way to overwrite hl by user choice if we add it to the plugin. If there isn't, it'd suck to add it, IMHO.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Lets confirm it for now to get the unconfirmed list cleaner.

Comment 6

[Sebastien Marinier]

Google changed the way it handles Firefox queries. So, one year later, this proposition is now obsolete (don't know when they change it, as is used my modified search plugins). Thanks to Google.