Closed Bug 451040 Opened 11 years ago Closed 11 years ago

Passwords Manager Empty after convert to MozStorage

Categories

(Toolkit :: Password Manager, defect, blocker)

defect
Not set
blocker

Tracking

()

VERIFIED FIXED
mozilla1.9.1a2

People

(Reporter: jmjjeffery, Assigned: Dolske)

References

Details

(Keywords: dataloss, dogfood, regression)

Attachments

(1 file)

Starting with today's nightly build the Password Manager is Empty.

This appears in the Error Console:
Error: Cc[contractID] is undefined
Source file: file:///C:/Program%20Files/Minefield/components/nsLoginManager.js
Line: 112
Flags: blocking1.9.1?
OS: Windows Vista → All
There is also no 'Notification Bar' shown when adding a site that requires a login, and no signons3.txt is created at all, nor any password files that I see other than key3.db

Above noted with a new profile, no addons.
Keywords: dataloss
Pretty sure this breaks signins to Weave, too.
(In reply to comment #2)
> Pretty sure this breaks signins to Weave, too.
> 

I can confirm this. Weave would not sign in. Even the dialog box was not
populated with password nor passphrase. Weave just sat there when I tried
inputting them and then trying to log in. I have reverted to yesterday's
nightly and am now signed in.

Also, FYI-Logins and passwords are accessible in yesterday's nightly under Tools > Options > Security > Passwords > Saved Passwords...
Keywords: dogfood
Duplicate of this bug: 451019
(In reply to comment #0)
> This appears in the Error Console:
> Error: Cc[contractID] is undefined
> Source file: file:///C:/Program%20Files/Minefield/components/nsLoginManager.js
> Line: 112
That's strange.  The tests should not be passing if that fails :(
Maybe this file needs to be added to packages-static?
Ugh, yes, packages-static is almost certainly the problem. *sigh*
Attached patch Patch v.1Splinter Review
This bit us in the original password manager landing (bug 374723 comment 29), too. You'd think we'd learn. :)
Assignee: nobody → dolske
Status: NEW → ASSIGNED
Attachment #334300 - Flags: review?(gavin.sharp)
Attachment #334300 - Flags: review?(gavin.sharp) → review+
What's strange is that unit test boxes used to not work with the component either when it wasn't in packages-static.  So, why did they not go orange this time?
Depends on: 451059
Pushed changeset c37a5b4ed1af.

Filed bug 451059 to have the tinderboxen clobbered, so that nightly users will get a fixed update ASAP.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: blocking1.9.1?
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
You can clobber yourself by modifying the CLOBBER file:
http://mxr.mozilla.org/mozilla/source/tools/tinderbox-configs/firefox/win32/
(and macosx/ and linux/)
Target Milestone: mozilla1.9.1a2 → ---
(In reply to comment #11)
> You can clobber yourself by modifying the CLOBBER file:
> http://mxr.mozilla.org/mozilla/source/tools/tinderbox-configs/firefox/win32/
> (and macosx/ and linux/)

That only works for CVS, FYI.

Confirmed that "Check for Updates" on Windows is pulling Gecko/20080818113442, and it created signons.sqlite as expected.
Status: RESOLVED → VERIFIED
Hardware: PC → All
Target Milestone: --- → mozilla1.9.1a2
This bug re-appears with hightly 20090116
Nope, current nightly works fine for me.

This bug has been closed for 5 months. If you can reproduce your problem, open a new bug with logging from https://wiki.mozilla.org/Firefox:Password_Manager_Debugging
I think he is using SeaMonkey trunk builds. 20090116 is when the toolkit login manager landed in comm-central (SeaMonkey+Thunderbird). In any case Igor, please file a new bug if you can come up with a consistent test case.
You need to log in before you can comment on or make changes to this bug.