451040 - Passwords Manager Empty after convert to MozStorage

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Starting with today's nightly build the Password Manager is Empty.

This appears in the Error Console:
Error: Cc[contractID] is undefined
Source file: file:///C:/Program%20Files/Minefield/components/nsLoginManager.js
Line: 112

Comment 1

[Jim Jeffery not reading bug-mail 1/2/11]

There is also no 'Notification Bar' shown when adding a site that requires a login, and no signons3.txt is created at all, nor any password files that I see other than key3.db

Above noted with a new profile, no addons.

Comment 2

[aja+bugzilla]

Pretty sure this breaks signins to Weave, too.

Comment 3

[WildcatRay]

(In reply to comment #2)
> Pretty sure this breaks signins to Weave, too.
> 

I can confirm this. Weave would not sign in. Even the dialog box was not
populated with password nor passphrase. Weave just sat there when I tried
inputting them and then trying to log in. I have reverted to yesterday's
nightly and am now signed in.

Also, FYI-Logins and passwords are accessible in yesterday's nightly under Tools > Options > Security > Passwords > Saved Passwords...

Comment 5

[Shawn Wilsher :sdwilsh]

(In reply to comment #0)
> This appears in the Error Console:
> Error: Cc[contractID] is undefined
> Source file: file:///C:/Program%20Files/Minefield/components/nsLoginManager.js
> Line: 112
That's strange.  The tests should not be passing if that fails :(

Comment 6

[Shawn Wilsher :sdwilsh]

Maybe this file needs to be added to packages-static?

Comment 7

[Justin Dolske [:Dolske]]

Ugh, yes, packages-static is almost certainly the problem. *sigh*

Comment 8

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

This bit us in the original password manager landing (bug 374723 comment 29), too. You'd think we'd learn. :)

Comment 9

[Shawn Wilsher :sdwilsh]

What's strange is that unit test boxes used to not work with the component either when it wasn't in packages-static.  So, why did they not go orange this time?

Comment 10

[Justin Dolske [:Dolske]]

Pushed changeset c37a5b4ed1af.

Filed bug 451059 to have the tinderboxen clobbered, so that nightly users will get a fixed update ASAP.

Comment 11

[Steffen Wilberg]

You can clobber yourself by modifying the CLOBBER file:
http://mxr.mozilla.org/mozilla/source/tools/tinderbox-configs/firefox/win32/
(and macosx/ and linux/)

Comment 12

[(not currently active) Ted Mielczarek]

(In reply to comment #11)
> You can clobber yourself by modifying the CLOBBER file:
> http://mxr.mozilla.org/mozilla/source/tools/tinderbox-configs/firefox/win32/
> (and macosx/ and linux/)

That only works for CVS, FYI.

Comment 13

[Justin Dolske [:Dolske]]

Confirmed that "Check for Updates" on Windows is pulling Gecko/20080818113442, and it created signons.sqlite as expected.

Comment 14

[Igor Velkov]

This bug re-appears with hightly 20090116

Comment 15

[Justin Dolske [:Dolske]]

Nope, current nightly works fine for me.

This bug has been closed for 5 months. If you can reproduce your problem, open a new bug with logging from https://wiki.mozilla.org/Firefox:Password_Manager_Debugging

Comment 16

[Philip Chee]

I think he is using SeaMonkey trunk builds. 20090116 is when the toolkit login manager landed in comm-central (SeaMonkey+Thunderbird). In any case Igor, please file a new bug if you can come up with a consistent test case.