Closed
Bug 451123
Opened 17 years ago
Closed 17 years ago
[FIX]"ASSERTION: Don't call SetValueInternal for file inputs"
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jruderman, Assigned: bzbarsky)
Details
(Keywords: assertion, testcase, Whiteboard: [sg:nse])
Attachments
(3 files)
|
76 bytes,
text/html
|
Details | |
|
3.16 KB,
patch
|
Details | Diff | Splinter Review | |
|
3.11 KB,
patch
|
sicking
:
review+
sicking
:
superreview+
|
Details | Diff | Splinter Review |
<input type="file" type="file"> triggers:
###!!! ASSERTION: Don't call SetValueInternal for file inputs: 'mType != NS_FORM_INPUT_FILE', file /Users/jruderman/central/content/html/content/src/nsHTMLInputElement.cpp, line 918
This assertion was added in the patch for bug 334977.
Assertions are always bad, but there is currently no way to exploit this.
Whiteboard: [sg:nse]
|
Assignee | |
Comment 2•17 years ago
|
||
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•17 years ago
|
Summary: "ASSERTION: Don't call SetValueInternal for file inputs" → [FIX]"ASSERTION: Don't call SetValueInternal for file inputs"
|
|
Assignee | |
Comment 3•17 years ago
|
||
Attachment #334733 -
Flags: superreview?(jonas)
Attachment #334733 -
Flags: review?(jonas)
Comment on attachment 334733 [details] [diff] [review]
Same as diff -w
>+++ mozilla/content/html/content/crashtests/451123-1.html 2008-08-20 14:53:32.000000000 -0400
>@@ -0,0 +1,7 @@
>+<html>
>+<head>
>+</head>
>+<body>
>+<input type="file" type="file">
>+</body>
>+</html>
>\ No newline at end of file
might want to add an ending newline
Attachment #334733 -
Flags: superreview?(jonas)
Attachment #334733 -
Flags: superreview+
Attachment #334733 -
Flags: review?(jonas)
Attachment #334733 -
Flags: review+
|
Reporter | |
Updated•17 years ago
|
Attachment #334725 -
Attachment is patch: true
Attachment #334725 -
Attachment mime type: application/octet-stream → text/plain
|
|
Assignee | |
Comment 5•17 years ago
|
||
Pushed changeset ff36dafe320d with that change.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•