451256 - Visiting page without title after visiting a page with a title keeps the title of the previous page

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Martijn Wargers (dead)]

This has to be a regression from bug 118704.

To reproduce:
- Visit this page
- Visit a page without a title, for instance: http://martijn.martijn.googlepages.com/scrollbar.css

Result:
The title of this page is still shown in in the window titlebar in the new, title-less page.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

That's weird. The tab title *does* change. This is probably a chrome bug that I just exposed.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

The tab title is set OK because it changes to "Loading" and then eventually we reset it again. The window title is not changed to "Loading" so we just never change it since no DOMTitleChanged event is fired.

This patch makes us update the window title (and also the tab title, if necessary) in onLocationChange, which fires when the tab's docshell switches to a new contentviewer. I think this is logical. We could fire additional DOMTitleChanged events but that seems less clean to me since document titles aren't really changing, we're just switching which document is displayed.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: different fix

Gavin just wanted to revert to the old behaviour, where we dispatch DOMTitleChanged in nsContentSink::DidBuildModelImpl if no event has already been dispatched. I'm not sure that's entirely logical but I can see the advantage of compatibility so here it is.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed f50234e5a17b.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I thought about writing a test for this. The problem is, you really need a chrome event listener on the iframe's docshell, which is a bit of a pain.

Comment 6

[Charles Fenwick]

Verified.

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1b3pre) Gecko/20090130 Shiretoko/3.1b3pre