451316 - "ASSERTION: unexpected frame type" with -moz-column

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: unexpected frame type: 'Not Reached', file /Users/jruderman/central/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 10378

###!!! ASSERTION: reflow dirty lines failed: 'NS_SUCCEEDED(rv)', file /Users/jruderman/central/mozilla/layout/generic/nsBlockFrame.cpp, line 963

Comment 1

[Jesse Ruderman]

Still happens on trunk.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The frame passed to CreateContinuingFrame is an nsComboboxControlFrame.

Comment 3

[Boris Zbarsky [:bzbarsky]]

And it looks like changing the return value of GetSplittableType (is that used outside of asserts?) does nothing.  Do combobox and lisbox need to make sure they never return an incomplete reflow status or something?

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes!

Comment 5

[Mats Palmgren (inactive)]

WFM.  I think it might have been fixed by bug 959311.
I added <select multiple> to the test and landed it as a crashtest.
https://hg.mozilla.org/integration/mozilla-inbound/rev/23be1cc02247

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/23be1cc02247