451356 - no error page when going offline too quickly after entering a URL

Status: NEW

(Core :: Networking: HTTP, defect, P5)

Description

[Simon Bünzli]

Steps to reproduce:
1. Open a new tab
2. Enter a URL to a not too quickly responding server (https preferred, so e.g. a bugzilla.mozilla.org page)
3. After hitting Enter/Go, quickly enable offline mode

Steps to reproduce (on Windows with an en-US build):
1. Focus the address bar
2. Keep the Alt-key down and hit Enter, F, W

Expected result:
The Offline Mode error page is displayed so that we can easily Try Again to load that address.

Actual result:
A blank page is displayed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Not a docshell issue.  When you go offline, all in-flight HTTP requests get canceled by necko, with the NS_ERROR_ABORT code.  Nothing to indicate to docshell that offline is involved.

Comment 2

[Boris Zbarsky [:bzbarsky]]

And for what it's worth, all HTTP knows is that the socket is no longer accessible and returns NS_ERROR_ABORT when accessed.

The source of the NS_ERROR_ABORT is nsSocketTransport::OnSocketDetached. All it knows is that the socket is being killed by someone (in this case the socket transport service shutting down).

I suppose we could propagate a status code from socket transport service shutdown through socket detach and so forth.  Patches probably accepted if they don't break anything.  ;)

Comment 3

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258