Closed
Bug 451361
Opened 17 years ago
Closed 17 years ago
Junk settings should allow using read only address books but not remote ones for white lists
Categories
(MailNews Core :: Filters, defect)
MailNews Core
Filters
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file)
643 bytes,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
The current implementation of the Junk settings pane in the account manager, only allows writeable address books to be used as white lists, however, the junk functions only ever call cardForEmailAddress which is a read-only function.
Therefore we should change this restriction to not-remote, and allow read-only address books. This means we can include the OS X Address book interface as a white list option, but still ignore LDAP books.
Attaching patch...
Attachment #334665 -
Flags: superreview?(neil)
Attachment #334665 -
Flags: review?(neil)
Flags: wanted-thunderbird3+
Comment 1•17 years ago
|
||
Comment on attachment 334665 [details] [diff] [review]
The fix
Looks like the Outlook address books count as writeable, but this doesn't break anything on Windows.
Attachment #334665 -
Flags: superreview?(neil)
Attachment #334665 -
Flags: superreview+
Attachment #334665 -
Flags: review?(neil)
Attachment #334665 -
Flags: review+
Assignee | ||
Comment 2•17 years ago
|
||
Checked in, changetset id: 147:184273b99f26
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
You need to log in
before you can comment on or make changes to this bug.
Description
•