451506 - The return values of PR_Seek64 and PR_Available64 should be checked in FileImpl::Seek or else file corruption will occur

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Hiroyuki Ikezoe (:hiro)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.15) Gecko/20080702 Ubuntu/8.04 (hardy) Firefox/2.0.0.15 Kazehakase/0.5.4
Build Identifier: 

The return values of PR_Seek64 and PR_Available64 should be checked in  FileImpl::Seek or else file corruption will occur.

When call Seek(NS_SEEK_END, 0), if PR_Available64 fails then fileSize become wrong value. So file pointer does not move to end of file.




Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Check both values [Checkin: Comment 9]

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I suspect BUG 432514 was caused by this issue.

Comment 3

[[e-mail]]

Comment on attachment 334836 [details] [diff] [review]
Check both values
[Checkin: Comment 9]

You need an XPCOM reviewer for this.

Comment 4

[Benjamin Smedberg]

Comment on attachment 334836 [details] [diff] [review]
Check both values
[Checkin: Comment 9]

r=me, although this code really just needs to die

Comment 5

[Hiroyuki Ikezoe (:hiro)]

I agree. But Thunderbird 2.0.0.x still uses this code. I don't think that cleanup XPCOM/obsolete codes from Thunderbird is good for its stability.

Comment 6

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 334836 [details] [diff] [review]
Check both values
[Checkin: Comment 9]

the patch will raise stability.

Comment 7

[Samuel Sidler (old account; do not CC)]

Comment on attachment 334836 [details] [diff] [review]
Check both values
[Checkin: Comment 9]

This will have to get looked at in 1.8.1.18. We're frozen.

Comment 8

[Daniel Veditz [:dveditz]]

Comment on attachment 334836 [details] [diff] [review]
Check both values
[Checkin: Comment 9]

Approved for 1.8.1.18, a=dveditz for release-drivers

Comment 9

[Reed Loden [:reed]]

http://hg.mozilla.org/mozilla-central/rev/6601dacc93f7

Comment 10

[Daniel Veditz [:dveditz]]

Patch checked into the 1.8 branch