451618 - Previews in ctrl-tab/all-tabs panel are not updated consistently (empty or outdated image)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080821020645 Minefield/3.1a2pre ID:20080821020645

In some situations the preview images are not updated and show no or an outdated image.

Use the following STR to see an empty (not updated from blank tab) preview:
1. Open Firefox with one tab open and e.g. the homepage loaded
2. Click Cmd+T/Ctrl+T twice to get three tabs
3. Open the homepage within the 3rd tab
4. Press Ctrl+Tab to switch to the second tab
=> Verify that both previews are shown
5. Open the homepage within the 2nd tab
6. Press Ctrl+Tab to switch back to the 3rd tab
=> Verify that for the current active tab there is no preview shown
7. Press again Ctrl+Tab
=> Verify that all previews are shown

Even when navigating through pages the previews are not updated:
1. Repeat steps 1-6 from the above STR
2. Click on any URL which is referenced from your homepage
3. Wait until the target page is loaded and press Ctrl+Tab
=> Verify that the preview still shows the capture from the homepage

This is reproducibly on Windows and OS X.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, I forgot that this also happens for the upcoming all-tabs panel. I have tested the tryserver build mentioned in bug 436304 comment 24. I'll attach a screenshot.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Outdated preview of last tab

As you can see Gmail is opened in background and the preview still shows the google start page while the title says "Google Mail". It can be reproduced by the first given STR.

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

simply invalidate previews if the location has changed

Comment 4

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/bb8cfffef4a9

Comment 5

[Shawn Wilsher :sdwilsh]

test please?

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified with Ctrl-Tab and following builds:

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b1pre) Gecko/20080901033305 Minefield/3.1b1pre ID:20080901033305

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b1pre) Gecko/20080901020926 Minefield/3.1b1pre ID:20080901020926