451789 - Duplicate emails sent from groups

Status: VERIFIED FIXED

(Websites Graveyard :: spreadfirefox.com, defect)

Description

[Alix Franquet [:alix]]

Sending email to members of a group (via the "email" tab of a given group) send 2 emails to each member.

Comment 1

[Alex Buchanan [:abuchanan]]

Paul could you verify this please?

Comment 2

[Alix Franquet [:alix]]

I created test groups on stage and production and could not reproduce the problem for a new group with 3 members.

Should this be tested for a larger group?

Comment 3

[Alex Buchanan [:abuchanan]]

are you still getting duplicate emails from production?

Comment 4

[Alix Franquet [:alix]]

No. However, when sending an email to a larger group (in this case 102 members), the browser timed out waiting for confirmation. The email was sent though.

This makes me think that Drupal still waits for all the emails to be sent before showing the confirmation page. Wasn't job_queue supposed to solve this? Or is it not helping with the Email tab (different from automatic email notification of group posts).

Comment 5

[Paul Booker]

I have just installed / configured Job Queue

http://www.spreadfirefox.com/admin/logs/job_queue
http://www.spreadfirefox.com/admin/settings/job_queue

OG mail should now be queued .

Comment 6

[Paul Booker]

Attachment: Allow Job Queue to schedule the release of newsletter mail generated by the group manager

Allow Job Queue to schedule the release of newsletter mail generated by the group manager

Comment 7

[Paul Booker]

The changes have been commited, r18877

Comment 8

[Paul Booker]

Closing this discussion as there have been no further replies over the last month. If the last commit has not resolved the issue please reopen and ill investigate further.

Best, Paul

Comment 9

[Alix Franquet [:alix]]

This is not resolved, since we need to find a way to test whether or not it is fixed (without sending emails to the actual sfx users). 
How can we test this?

Comment 10

[Paul Booker]

If the patch works for groups with a small number of members on stage and we can't think of any reason why it will not work for any group with a large number of members then my thinking is that if our expectations are such that pushing through this patch to production will have no negative effects and should resolve the problem completely then we should push the changes through to production.

Paul

Comment 11

[Mary]

Hey all:  Is this resolved?  It sounds like Jay is sending emails to campus reps now problem :)

Can we re-enable email notifications for group activity now?

Comment 12

[Jay Patel [:jay]]

Well, just to be clear:  I sent an email to the campus reps group (2300+ members)... not sure if all of those users are legit with valid emails, but I did get a confirmation that the messages were sent.

I have no idea if duplicate message went out, but I only clicked the send button once (and have not heard anything from any reps that they got multiple emails).

So if people were waiting for a successful testcase... this was it, it worked as I expected it to. ;-)

Comment 13

[Paul Booker]

I got this single message on the 14th ..

Hey Campus Reps!

It's been while since I've sent a note to the group list on SpreadFirefox... but wanted to let you know about our Mozilla Community Team meeting tomorrow: http://www.spreadfirefox.com/node/3453

We plan to spend a few minutes brainstorming on where to take the Campus Reps program in 2009... so I hope you can make it.

Also, if you haven't gotten my recent emails, you need to join our mailing list (it's separate/different than this SFX group list)... go here: https://mail.mozilla.org/listinfo/campusreps-all

That way you will get all of my updates and notifications.  We will be starting the new registration process soon, so make sure you're connected! :-)

Thanks.
- Jay, your Campus Reps coordinator

--
This message was sent by an administrator in the 'Mozilla Campus Reps' group at Spread Firefox. To visit this group, browse to http://www.spreadfirefox.com/campusreps. To unsubscribe from this group, visit http://www.spreadfirefox.com/og/unsubscribe/256

Comment 14

[Jay Patel [:jay]]

(In reply to comment #13)
> I got this single message on the 14th ..

I guess that means at my message to 2000+ members wasn't sent multiple times at least. :-)

Comment 15

[Paul Booker]

We need to change track here ..

Currenty were using the job queue module and making modifications to the OG module better we should use the notification module which is the framework OG now uses for notifying users about posts.

http://drupal.org/project/notifications

Investigating ..

Comment 16

[Paul Booker]

Committed into SVN notifications r22549 and its dependencies token r22547 and messaging r22548 . I also took the opportunity to delete job_queue r22545 as it will no longer be needed and site_map r22546 as it is not used.

Will now set OG notifications on stage for final testing ...

Comment 17

[Paul Booker]

Everything we need is now working, just needs further configuring 

Some notes ..

All user account pages now have a "notifications" tab which links to page where they can subscribe to wide range of notifications.

A group manager can click on the "broadcast" tab on his group page which links to a page where he can post to his subscribers

Some useful links ..
https://spreadfirefox.authstage.mozilla.com/admin/messaging
https://spreadfirefox.authstage.mozilla.com/admin/messaging/notifications-status

Currently all messaging is queued for delivery and needs to be released either by 
1. Running the queue process
2. Running the cron (Using the devel module block)

Best, Paul

Comment 18

[Paul Booker]

Resolving this bug as fixed. 

Please let me know if you need any further assistance.

Best, Paul

Comment 19

[Mary]

Hey there:  Anyway we can test this?  At that point, we can turn it on, right?

Comment 20

[Paul Booker]

To test we need someone else who can create groups / users and has administrative privileges to configure notifications.

Comment 21

[Mary]

Hey Paul:  I can test this it sounds like.  So to confirm this is working on stage and email notifications are on?

Comment 22

[Paul Booker]

In an word "yes" . I'll be online a little later ..

Comment 23

[Mary]

Alix and I just created a group on stage and she sent a message using the "broadcast" tab, created a document and a discussion topic. So far nothing, but might be a touch early :)

Comment 24

[Paul Booker]

https://spreadfirefox.authstage.mozilla.com/admin/messaging/notifications-status/queue

or have cron.php run

Paul

Comment 25

[Paul Booker]

Sorry ,that should have been .....

To process the queue you can either "Run queue process" over @

https://spreadfirefox.authstage.mozilla.com/admin/messaging/notifications-status/queue

or have cron.php run

Paul

Comment 26

[Mary]

Hey there:  There are 450 messages in the queue!  Can we delete these and start over?  I have no idea who these emails would go to.

Also, is this a manual process that needs to happen to get all messages sent?

Comment 27

[Paul Booker]

Yep , i have reset the queue.

For now you can release messages manually for testing purposes. 

When running on production they should be released automatically at regular intervals on a cron schedule.

Paul

Comment 28

[Alix Franquet [:alix]]

Paul: when you say they should, is it that they will the way things are currently set up or that we'll need to do something to make sure it happens?

Comment 29

[Paul Booker]

"they will the way things are currently set up"

Comment 30

[Mary]

Is chron on?  Tested this again and no note...

Comment 31

[Stephen Donner [:stephend] Not actively reading bugmail]

This seems fixed to me; I sent messages to both Alex's test project and my own, and got only one message per group:

http://www.grabup.com/uploads/f86547219188a42c68b5986e3edfb667.png

Comment 32

[Stephen Donner [:stephend] Not actively reading bugmail]

Really meant to verify this the first time around; doing so now (Krupa, et al; please reopen if you still see this -- I tested with a couple emails to different groups).