451811 - comm-central's client.py needs ability to pull specific revisions/tags

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Justin Wood (:Callek)]

With our client.py we need the ability to pull specific revisions/tags.

Comment 1

[Justin Wood (:Callek)]

Attachment: v1.0

roughly tested.

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 335197 [details] [diff] [review]
v1.0

per IRC, not really ready.

the |hg pull -u -r <rev>| fails when local revision history already includes <rev> (or if rev is backwards in history), so a combination of |hg pull| and |hg update| will be needed.

Comment 3

[Andrew Schultz]

hg update also supports specifying a date (-d date), which would be useful for regression hunting.  I can file a new bug if you'd rather not do that here.

Comment 4

[Justin Wood (:Callek)]

Attachment: v1.1

this should do it. the -d thing ajschult mentioned I'd like to only worry about in a new bug

Comment 5

[(not currently active) Ted Mielczarek]

FWIW, the -d requires an exact commit date, and that date is the *commit* date, not when the change was pushed to mozilla-central/comm-central/whatever, so it's not terribly useful for regression finding.

Comment 6

[Robert Kaiser]

Comment on attachment 335530 [details] [diff] [review]
v1.1

From what I can test, this seems to work, thanks (it's actually hard to test this on comm-central, due to hg update not liking trees that have patches/queues applied very much).

Comment 7

[Justin Wood (:Callek)]

$ hg push
pushing to ssh://hg.mozilla.org/comm-central/
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files

$ hg tip -v
changeset:   223:abb590b3397d
tag:         tip
user:        Justin Wood <[e-mail]>
date:        Fri Aug 29 10:40:21 2008 -0400
files:       client.py
description:
Bug 451811, comm-central's client.py needs ability to pull specific revisions/tags
r=KaiRo

Comment 8

[David Ascher (:davida)]

Callek asked me for a look at the python code.   looks fine to me.