Closed
Bug 451919
Opened 16 years ago
Closed 13 years ago
Remove |APP_XPCOM_LIBS| from /calendar/sunbird/
Categories
(Calendar :: Sunbird Only, defect)
Calendar
Sunbird Only
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sgautherie, Assigned: ewong)
References
()
Details
Attachments
(1 file)
|
598 bytes,
patch
|
Fallen
:
review+
sgautherie
:
feedback+
|
Details | Diff | Splinter Review |
Port |Bug 451871 – Remove |MOZILLA_INTERNAL_API| from /suite/| to Calendar.
|
||
Comment 1•16 years ago
|
||
Calendar core code already is ready for frozen linkage (just compiles non-frozen on branch). Only Sunbird may need some changes.
|
Reporter | |
Comment 2•16 years ago
|
||
Yeah, that's what the URL shows.
Making summary more explicit.
Summary: Remove |APP_XPCOM_LIBS| from /calendar/ → Remove |APP_XPCOM_LIBS| from /calendar/sunbird/
|
||
Comment 3•16 years ago
|
||
Adding dependency to Bug 451871. Once that bug is fixed we might port it.
Depends on: 451871
|
Assignee | |
Comment 4•13 years ago
|
||
With bug #680753 pending checkin-needed, wouldn't this bug be invalid?
|
||
Updated•13 years ago
|
Component: Build Config → Sunbird Only
QA Contact: build → sunbird
|
|
Reporter | |
Comment 5•13 years ago
|
||
(In reply to Stefan Sitter from comment #3)
> Adding dependency to Bug 451871. Once that bug is fixed we might port it.
This bug can (now) be done without waiting for bug 451871.
Severity: normal → trivial
No longer depends on: 451871
Flags: in-testsuite-
Whiteboard: [good first bug][mentor=sgautherie]
|
|
Reporter | |
Comment 6•13 years ago
|
||
ToDo: simply replace the variable by its value then remove the former.
Whiteboard: [good first bug][mentor=sgautherie] → [good first bug][mentor=sgautherie][lang=make]
|
|
Assignee | |
Comment 7•13 years ago
|
||
|
|
Reporter | |
Updated•13 years ago
|
Attachment #602336 -
Flags: feedback+
|
||
Updated•13 years ago
|
Attachment #602336 -
Flags: review?(philipp) → review+
|
|
Assignee | |
Comment 8•13 years ago
|
||
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/a5bedd2e41b1
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [good first bug][mentor=sgautherie][lang=make]
You need to log in
before you can comment on or make changes to this bug.
Description
•