Remove |APP_XPCOM_LIBS| from /calendar/sunbird/

RESOLVED FIXED

Status

Calendar
Sunbird Only
--
trivial
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: ewong)

Tracking

Bug Flags:
in-testsuite -

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

9 years ago
Port |Bug 451871 – Remove |MOZILLA_INTERNAL_API| from /suite/| to Calendar.
Calendar core code already is ready for frozen linkage (just compiles non-frozen on branch). Only Sunbird may need some changes.
(Reporter)

Comment 2

9 years ago
Yeah, that's what the URL shows.
Making summary more explicit.
Summary: Remove |APP_XPCOM_LIBS| from /calendar/ → Remove |APP_XPCOM_LIBS| from /calendar/sunbird/

Comment 3

9 years ago
Adding dependency to Bug 451871. Once that bug is fixed we might port it.
Depends on: 451871
(Assignee)

Comment 4

6 years ago
With bug #680753 pending checkin-needed,  wouldn't this bug be invalid?
Component: Build Config → Sunbird Only
QA Contact: build → sunbird
(Reporter)

Comment 5

6 years ago
(In reply to Stefan Sitter from comment #3)
> Adding dependency to Bug 451871. Once that bug is fixed we might port it.

This bug can (now) be done without waiting for bug 451871.
Severity: normal → trivial
No longer depends on: 451871
Flags: in-testsuite-
Whiteboard: [good first bug][mentor=sgautherie]
(Reporter)

Updated

6 years ago
Depends on: 680753
(Reporter)

Comment 6

6 years ago
ToDo: simply replace the variable by its value then remove the former.
Whiteboard: [good first bug][mentor=sgautherie] → [good first bug][mentor=sgautherie][lang=make]
(Assignee)

Comment 7

6 years ago
Created attachment 602336 [details] [diff] [review]
Removed |APP_XPCOM_LIBS| from /calendar/sunbird/
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #602336 - Flags: review?(philipp)
(Reporter)

Updated

6 years ago
Attachment #602336 - Flags: feedback+
Attachment #602336 - Flags: review?(philipp) → review+
(Assignee)

Comment 8

6 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/a5bedd2e41b1
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Reporter)

Updated

6 years ago
Whiteboard: [good first bug][mentor=sgautherie][lang=make]
You need to log in before you can comment on or make changes to this bug.