Last Comment Bug 451927 - security/coreconf/WINNT6.0.mk has invalid defines
: security/coreconf/WINNT6.0.mk has invalid defines
Status: RESOLVED FIXED
:
Product: NSS
Classification: Components
Component: Build (show other bugs)
: trunk
: x86 Windows Vista
: P2 normal (vote)
: 3.12.2
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-08-23 23:43 PDT by Makoto Kato [:m_kato]
Modified: 2008-08-27 17:41 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
a patch v1 (2.83 KB, patch)
2008-08-23 23:43 PDT, Makoto Kato [:m_kato]
julien.pierre: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2008-08-23 23:43:45 PDT
Created attachment 335237 [details] [diff] [review]
a patch v1

coreconf/WINNT6.0.mk has invalid defines (duplicated conf file?).   We should remove this.

See http://mxr.mozilla.org/mozilla/source/security/coreconf/WINNT6.0.mk
Comment 1 Wan-Teh Chang 2008-08-23 23:55:09 PDT
Comment on attachment 335237 [details] [diff] [review]
a patch v1

Julien, could you review this patch?  WINNT6.0.mk rev. 1.2
was your checkin.
Comment 2 Julien Pierre 2008-08-24 15:49:15 PDT
Comment on attachment 335237 [details] [diff] [review]
a patch v1

I have no idea how this happened. I guess I did not test the build on Vista.
Comment 3 Julien Pierre 2008-08-27 17:41:19 PDT
I checked in the ptach on behalf on Makoto .
Checking in WINNT6.0.mk;
/cvsroot/mozilla/security/coreconf/WINNT6.0.mk,v  <--  WINNT6.0.mk
new revision: 1.3; previous revision: 1.2
done

Note You need to log in before you can comment on or make changes to this bug.