451943 - <video> element causes assertion PR_TRUE == cvar->lock->locked

Status: VERIFIED WORKSFORME

(Core :: Audio/Video, defect)

Description

[georgi - hopefully not receiving bugspam]

Attachment: testcase - media1.html

reloading
<video id="m1" src="/png.png"></video>

fires gdb due to assertion:
#4  <signal handler called>
#5  0x00007f4fdd099095 in raise () from /lib/libc.so.6
#6  0x00007f4fdd09aaf0 in abort () from /lib/libc.so.6
#7  0x00007f4fe1ec4c18 in PR_Assert (
    s=0x7f4fe1ef1ffb "PR_TRUE == cvar->lock->locked", 
    file=0x7f4fe1ef1ea0 "/opt/pub/firefox-central/src/nsprpub/pr/src/pthreads/ptsynch.c", ln=302) at /opt/pub/firefox-central/src/nsprpub/pr/src/io/prlog.c:577
#8  0x00007f4fe1ee002c in pt_PostNotifyToCvar (cvar=0x7f4fd0fdc300, 
    broadcast=1)
    at /opt/pub/firefox-central/src/nsprpub/pr/src/pthreads/ptsynch.c:302
#9  0x00007f4fe1ee062f in PR_NotifyAllCondVar (cvar=0x7f4fd0fdc300)
    at /opt/pub/firefox-central/src/nsprpub/pr/src/pthreads/ptsynch.c:440
#10 0x0000000000ca4d33 in nsOggDecoder::Stop (this=0x7f4fd14e5560)
    at /opt/pub/firefox-central/src/content/media/video/src/nsOggDecoder.cpp:510
#11 0x0000000000b3a8e4 in nsHTMLMediaElement::PickMediaElement (
    this=0x7f4fd0fe7b30, aChosenMediaResource=@0x7fffeb4292b0)
    at /opt/pub/firefox-central/src/content/html/content/src/nsHTMLMediaElement.---Type <return> to continue, or q <return> to quit---
cpp:539
#12 0x0000000000b3ae42 in nsHTMLMediaElement::Load (this=0x7f4fd0fe7b30)
    at /opt/pub/firefox-central/src/content/html/content/src/nsHTMLMediaElement.cpp:209
#13 0x0000000000b3d663 in nsHTMLVideoElement::Load (this=0x7f4fd0fe7b30)
    at ../../../../dist/include/content/nsHTMLVideoElement.h:62
#14 0x00007f4fe25e160c in NS_InvokeByIndex_P (that=0x7f4fd0fe7b90, 
    methodIndex=64, paramCount=0, params=0x7fffeb4295d0)
    at /opt/pub/firefox-central/src/xpcom/reflect/xptcall/src/md/unix/xptcinvoke_x86_64_linux.cpp:208
#15 0x0000000000610bec in XPCWrappedNative::CallMethod (ccx=@0x7fffeb429a10, 
    mode=XPCWrappedNative::CALL_METHOD)
    at /opt/pub/firefox-central/src/js/src/xpconnect/src/xpcwrappednative.cpp:2393
#16 0x000000000061cc97 in XPC_WN_CallMethod (cx=0x7f4fd1802c00, 
    obj=0x7f4fd0fdecc0, argc=0, argv=0x7f4fd1574160, vp=0x7fffeb429bb8)
    at /opt/pub/firefox-central/src/js/src/xpconnect/src/xpcwrappednativejsops.cpp:1473
#17 0x00007f4fe2b0d9cd in js_Invoke (cx=0x7f4fd1802c00, argc=0,

Comment 3

[cajbir (:cajbir)]

The issue here is caused by not acting on errors reported from the ogg libraries that the format of the Ogg is invalid. A fix for this was in bug 449159 but was removed before committing so more thought could be given to it, tests written, etc.

Comment 4

[cajbir (:cajbir)]

This no longer occurs on trunk due to the Ogg backend rewrite. I was also unable to reproduce it on a recent Firefox 3.6 build. Can you confirm if this issue still exists?

Comment 5

[u279076]

Verified WORKSFORME using Firefox 4.0b10build1.