Closed
Bug 452075
Opened 17 years ago
Closed 17 years ago
Clean up the bookmark editor dialog
Categories
(Firefox for Android Graveyard :: Bookmarks, defect, P2)
Firefox for Android Graveyard
Bookmarks
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0a1
People
(Reporter: madhava, Assigned: mfinkle)
Details
(Whiteboard: UI polish)
Attachments
(1 file)
4.33 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
We have only a few modal dialogs (all of them overlays) in Fennec, but they mostly don't have a clear consistent method to dismiss them. The bookmarks and navigations (URL entry/search/awesomebar) screens are two examples of this. The "Edit bookmark" screen has a cancel button, but it should probably take on the method used by these other dialogs, once one is in place.
Reporter | ||
Updated•17 years ago
|
Whiteboard: UI polish
![]() |
||
Updated•17 years ago
|
Flags: blocking-fennec1.0+
Updated•17 years ago
|
Assignee: nobody → mark.finkle
Priority: -- → P2
Comment 2•17 years ago
|
||
mfinkle: since neil is away, can you try and get in a fix for this, at least for the awesomebar?
Assignee: enndeakin → mark.finkle
Assignee | ||
Comment 3•17 years ago
|
||
* Converts the bookmark editor panel to "instant apply"
* Removes "Done" and "Cancel" buttons (and the strings in the DTD)
* Adds a (X) style close button - just like the bookmark list panel
* Sets focus to the Name field on show
Attachment #341679 -
Flags: review?(gavin.sharp)
Updated•17 years ago
|
Attachment #341679 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Comment 4•17 years ago
|
||
http://hg.mozilla.org/mobile-browser/rev/1822be625a06
Let's take any other dialog fixups as separate bugs
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Summary: Need way to dismiss modal dialogs → Clean up the bookmark editor dialog
this has been rewritten 100% since this checkin...verified with beta3
Status: RESOLVED → VERIFIED
![]() |
||
Updated•16 years ago
|
Component: General → Bookmarks
You need to log in
before you can comment on or make changes to this bug.
Description
•