We have only a few modal dialogs (all of them overlays) in Fennec, but they mostly don't have a clear consistent method to dismiss them. The bookmarks and navigations (URL entry/search/awesomebar) screens are two examples of this. The "Edit bookmark" screen has a cancel button, but it should probably take on the method used by these other dialogs, once one is in place.
neil, can you take a look at this?
Assignee: mark.finkle → enndeakin
mfinkle: since neil is away, can you try and get in a fix for this, at least for the awesomebar?
Assignee: enndeakin → mark.finkle
Created attachment 341679 [details] [diff] [review] cleanup bookmark editor * Converts the bookmark editor panel to "instant apply" * Removes "Done" and "Cancel" buttons (and the strings in the DTD) * Adds a (X) style close button - just like the bookmark list panel * Sets focus to the Name field on show
Attachment #341679 - Flags: review?(gavin.sharp)
Attachment #341679 - Flags: review?(gavin.sharp) → review+
http://hg.mozilla.org/mobile-browser/rev/1822be625a06 Let's take any other dialog fixups as separate bugs
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Summary: Need way to dismiss modal dialogs → Clean up the bookmark editor dialog
this has been rewritten 100% since this checkin...verified with beta3
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.