452077 - Move bookmarks button to the titlebar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, defect, P3)

Description

[Madhava Enros [:madhava]]

The bookmarks list button (i.e. not the "star" bookmark creation button) should be moved to the title bar, as in this mockup:

http://people.mozilla.com/~madhava/files/mobile/2008-08-18/1.png

This is useful for a couple of reasons
- navigating to a bookmark is a primary task and is likely to be one of the first things a user does on opening the browser, so having the button be quickly accessible without summoning the control strip is useful
- seeing bookmarks is related to navigating and using the URL bar, so the new placement groups related functionality
- the button, on the title bar, is available even with the navigation screen occupies the screen, which means that the bookmarks list is available during already-begun navigation tasks (this is a essential)

Comment 1

[Stuart Parmenter]

gavin, can you work with madhava on this?

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Simple enough. Doesn't look perfect because the controls strip is wide and doesn't line up with the edge of the URL bar, but we can adjust that in the theming bug.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: screenshot

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 335744 [details] [diff] [review]
patch

Looks good. We should clean up the classes for the buttons when we make the good theme too.

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mobile-browser/rev/60dd20721284

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

heh, and now it is to the awesomebar in beta3.