Closed
Bug 452174
Opened 18 years ago
Closed 18 years ago
Make updater binary parent-pid command line arg optional
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(2 files)
|
1.65 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
|
2.54 KB,
patch
|
Details | Diff | Splinter Review |
I can see no reason that the parent-pid should be required.
|
Assignee | |
Comment 1•18 years ago
|
||
I will also attach a patch with whitespace changes
Attachment #335480 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•18 years ago
|
||
|
||
Updated•18 years ago
|
Attachment #335480 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•18 years ago
|
||
John, just a heads up... landing this in no way should not require a change to the build scripts... it will make it possible to just specify the path to the update.mar without additional arguments.
|
|
Assignee | |
Comment 4•18 years ago
|
||
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/index.cgi/rev/43e89bd626d27eb3574f5a3af9239b2fc24e7c97
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 5•18 years ago
|
||
John, one final note: bug 452128 is also needed to make this work
You need to log in
before you can comment on or make changes to this bug.
Description
•