452175 - Slice new verbatim design

Status: RESOLVED FIXED

(Webtools Graveyard :: Verbatim, defect)

Description

[Ryan Doherty (:rdoherty)]

Tracking bug for new verbatim design to be sliced.

Comment 1

[Wil Clouser [:clouserw]]

New design is looking great.  As requested from IRC, some changes:

1) Need a .widemodule class that inherits everything from .module but is the full browser width (or 980px if you like). 

2) We need a .nav-secondary class for the grey box at the top of pages like http://sm-cms01.mozilla.com:8081/en/languages/fr/.  Simple is fine - we can spruce it up later.

3) In the latest firefox nightly the nav-main header is on two lines.  Did something break in the nightly or is our design broken?  I can screenshot if you like but if it's broken for you you'll know it - it's very obvious.

Also adding some dependencies for already filed bugs.

Comment 2

[Wil Clouser [:clouserw]]

(In reply to comment #1)
> 3) In the latest firefox nightly the nav-main header is on two lines.  Did
> something break in the nightly or is our design broken?  I can screenshot if
> you like but if it's broken for you you'll know it - it's very obvious.

The header is fine normally but breaks after someone logs in.  Sounds like this one is just another view of bug 453247.

Comment 3

[Ryan Doherty (:rdoherty)]

Can I get a screenshot of the broken nav? Or an account on a dev instance with the new design so I can test.

Also, in order for me to create a module with 100% width, I'll need a new psd mockup with wider grey borders. I can't stretch the current ones.

Comment 4

[Wil Clouser [:clouserw]]

Attachment: widemod-borders.png

> Also, in order for me to create a module with 100% width, I'll need a new psd
> mockup with wider grey borders. I can't stretch the current ones.

I'll stretch them

Comment 5

[Ryan Doherty (:rdoherty)]

Attachment: Patch for widemodule, fixed nav when logged in and style secondary nav

Here's a patch to 

* add a widemodule (.module-primary) 

* fix the nav breaking when logged in (add class="logged-in" if logged in and add the classes "logged-in" and "admin" when logged in as admin)

* Slightly style the secondary nav so it's not so ugly. This really needs some UED lovin', there's so much crap/options in there it's hard to style.

Rename widemod-borders.png to mod-borders-wide.png and put in /img for the wide module to work.

I also cleaned up some of the layout to fix some tiny issues with centering.

Comment 6

[Ryan Doherty (:rdoherty)]

I also noticed all pages have the class "home" on the body tag. That's only for the real homepage, any other page should have no class.

Comment 7

[Wil Clouser [:clouserw]]

Thanks, everything up to here is committed.  I also did some other tweaks so be sure to svn up.

Comment 8

[Wil Clouser [:clouserw]]

Thanks so much Ryan!  New design has landed