Closed
Bug 452313
Opened 18 years ago
Closed 18 years ago
first run page for Fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
VERIFIED
FIXED
fennec1.0a1
People
(Reporter: madhava, Assigned: Gavin)
Details
(Whiteboard: UI polish)
Attachments
(1 file, 3 obsolete files)
|
294.36 KB,
patch
|
Details | Diff | Splinter Review |
We should have a first-run page for Fennec that, along with a welcome message and the Fennec branding, should convey visually where all the controls are. Something like "< Drag over here for tabs" and "Drag over here for controls >". Some visual, at the page edge, that could convey "there's more just over here" would be great.
Comment 1•18 years ago
|
||
Just my 2¢, but under the circumstances it should probably read "> Drag this direction for tabs" and "Drag this direction for controls <"
| Reporter | ||
Comment 2•18 years ago
|
||
From sean martell. See here for refernece:
http://www.seanmartell.com/fennec_splash/index.html
| Reporter | ||
Updated•18 years ago
|
Whiteboard: UI polish
Comment 3•18 years ago
|
||
Cool!
Perhaps the wording should be similar on both sides so "drag this way for tabs" instead?
| Reporter | ||
Updated•18 years ago
|
Assignee: madhava → gavin.sharp
Comment 4•18 years ago
|
||
Yea, that's pretty good.
| Assignee | ||
Comment 5•18 years ago
|
||
I created a new content package so that I could make it contentaccessible, and avoid giving the firstrun page chrome privs.
Attachment #339484 -
Flags: review?(mark.finkle)
| Reporter | ||
Comment 6•18 years ago
|
||
We should probably add, at some point, a link to "what's new" notes, or a "getting started with the web" page, as firefox does. Of course, that will have to wait until we have such content.
Comment 7•18 years ago
|
||
Comment on attachment 339484 [details] [diff] [review]
patch
(just adding what we talked about on IRC)
Can we move the firstrun content to a locale? (locales/en-US/firstrun/*)
Otherwise looks good to me.
Attachment #339484 -
Flags: review?(mark.finkle) → review-
| Assignee | ||
Comment 8•18 years ago
|
||
Now localizable. Not sure whether packaging firstrun.dtd in the separate JAR has any l10n impact, though. Madhava OKed the basic look, we can of course refine it iteratively once this is landed (we probably actually want to use the initial viewport height instead of the no-toolbar height, to avoid it being possible to "scroll up", though that means it will be scaled in the fullscreen mode, so that needs to look OK too).
Attachment #338240 -
Attachment is obsolete: true
Attachment #339484 -
Attachment is obsolete: true
Attachment #341483 -
Flags: review?(mark.finkle)
Comment 9•18 years ago
|
||
Comment on attachment 341483 [details] [diff] [review]
patch
nit: Could we put the firstrun files in subfolders, so they don't get lost when mixed in with the other files?
* chrome/content/firstrun (for the xhtml)
* chrome/skin/firstrun (for the css and images)
* locale/en-US/chrome/firstrun (for the dtd)
Attachment #341483 -
Flags: review?(mark.finkle) → review+
| Assignee | ||
Comment 10•18 years ago
|
||
Attachment #341483 -
Attachment is obsolete: true
| Assignee | ||
Comment 11•18 years ago
|
||
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 12•17 years ago
|
||
verified with beta3, although there is talk of a new updated version for 1.0
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•