452345 - nsCSSFrameConstructor "initial containing block" is misnamed

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

mInitialContainingBlock and GetInitialContainingBlock return the outermost frame for the root element. This is not the initial containing block, the variable should be renamed to mRootElementFrame and GetInitialContainingBlock removed in favour of GetRootElementFrame.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch for 452345

This patch handles the renaming.

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

You should probably request review for that patch by going to the attachment details page (you could also have done this when uploading the attachment), changing the review field to "?", and putting in ":roc" as the requestee.

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Attachment: Patch for 452345 1.1

Missed a couple instances the first time around.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 359160 [details] [diff] [review]
Patch for 452345 1.1

Looks good.

I guess IsInitialContainingBlock is unused? In a followup patch you could just remove it.

Comment 5

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Yep, it appears to be completely unused.  I'll take it out after this one lands.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed http://hg.mozilla.org/mozilla-central/rev/d7119b967560. Thanks!!