452401 - Create tests for mixed content

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Honza Bambas (:mayhemer)]

and probably for other more complicated stuff. This needs to land patch from bug 428009 that still doesn't compile on our linux build machine configured for test build.

Comment 1

[Honza Bambas (:mayhemer)]

Attachment: wip1

Preview of mixed content tests. There is a new js helper script allowing easy writing of new test. It automatically performs bfcache test (back and forward navigation). Some are based on tests from Kai's web, his manual tests are turned to automated.

Comment 2

[Honza Bambas (:mayhemer)]

Add tests for bug 455367, bug 472986.

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 353152 [details] [diff] [review]
wip1

I believe we urgently need these tests.

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 353152 [details] [diff] [review]
wip1

Thanks Honza!

But at the beginning of your patch you add prefs related to browser.download, are they really related to your security tests?

Comment 5

[Honza Bambas (:mayhemer)]

(In reply to comment #4)
> But at the beginning of your patch you add prefs related to browser.download,
> are they really related to your security tests?

I decided later to do it dynamically, during the test. I automated one of your manual tests for bug 383369 where download of a file is involved in STR. I will convert failing tests to TODO and land a new patch with fixing the prefs being set at run-time.

Comment 6

[Honza Bambas (:mayhemer)]

http://hg.mozilla.org/mozilla-central/rev/6d517e6e35bb

Comment 7

[Honza Bambas (:mayhemer)]

Attachment: As landed [Checked-in comment 6]

Comment 8

[Honza Bambas (:mayhemer)]

Looks like on optimized test-enabled builds these tests are not very stable. For now disabling (not backing out).

Comment 9

[Honza Bambas (:mayhemer)]

Attachment: Disabling tests [Checked-in comment 10]

Comment 10

[Honza Bambas (:mayhemer)]

http://hg.mozilla.org/mozilla-central/rev/cc2e2e847469

Comment 11

[Honza Bambas (:mayhemer)]

There are followups for all problems caused by this patch. No more need to keep this open.