Closed Bug 452401 Opened 11 years ago Closed 10 years ago

Create tests for mixed content

Categories

(Core Graveyard :: Security: UI, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mayhemer, Assigned: mayhemer)

References

(Depends on 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

and probably for other more complicated stuff. This needs to land patch from bug 428009 that still doesn't compile on our linux build machine configured for test build.
Attached patch wip1 (obsolete) — Splinter Review
Preview of mixed content tests. There is a new js helper script allowing easy writing of new test. It automatically performs bfcache test (back and forward navigation). Some are based on tests from Kai's web, his manual tests are turned to automated.
Add tests for bug 455367, bug 472986.
Attachment #353152 - Flags: review?(kaie)
Comment on attachment 353152 [details] [diff] [review]
wip1

I believe we urgently need these tests.
Comment on attachment 353152 [details] [diff] [review]
wip1

Thanks Honza!

But at the beginning of your patch you add prefs related to browser.download, are they really related to your security tests?
Attachment #353152 - Flags: review?(kaie) → review+
(In reply to comment #4)
> But at the beginning of your patch you add prefs related to browser.download,
> are they really related to your security tests?

I decided later to do it dynamically, during the test. I automated one of your manual tests for bug 383369 where download of a file is involved in STR. I will convert failing tests to TODO and land a new patch with fixing the prefs being set at run-time.
Status: NEW → ASSIGNED
Depends on: 478928
http://hg.mozilla.org/mozilla-central/rev/6d517e6e35bb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Attachment #353152 - Attachment is obsolete: true
Looks like on optimized test-enabled builds these tests are not very stable. For now disabling (not backing out).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → ASSIGNED
Attachment #362930 - Attachment description: Disabling tests → Disabling tests [Checked-in comment 10]
Depends on: 480713
Depends on: 487402
Depends on: 487632
There are followups for all problems caused by this patch. No more need to keep this open.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago10 years ago
Resolution: --- → FIXED
Depends on: 517938
Blocks: 524812
No longer blocks: 524812
Depends on: 734065
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.