Create tests for mixed content

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
2 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

(Depends on: 1 bug)

Trunk
x86
Windows XP
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
and probably for other more complicated stuff. This needs to land patch from bug 428009 that still doesn't compile on our linux build machine configured for test build.
(Assignee)

Comment 1

10 years ago
Created attachment 353152 [details] [diff] [review]
wip1

Preview of mixed content tests. There is a new js helper script allowing easy writing of new test. It automatically performs bfcache test (back and forward navigation). Some are based on tests from Kai's web, his manual tests are turned to automated.
(Assignee)

Comment 2

10 years ago
Add tests for bug 455367, bug 472986.
(Assignee)

Updated

10 years ago
Attachment #353152 - Flags: review?(kaie)
(Assignee)

Comment 3

10 years ago
Comment on attachment 353152 [details] [diff] [review]
wip1

I believe we urgently need these tests.

Comment 4

10 years ago
Comment on attachment 353152 [details] [diff] [review]
wip1

Thanks Honza!

But at the beginning of your patch you add prefs related to browser.download, are they really related to your security tests?
Attachment #353152 - Flags: review?(kaie) → review+
(Assignee)

Comment 5

10 years ago
(In reply to comment #4)
> But at the beginning of your patch you add prefs related to browser.download,
> are they really related to your security tests?

I decided later to do it dynamically, during the test. I automated one of your manual tests for bug 383369 where download of a file is involved in STR. I will convert failing tests to TODO and land a new patch with fixing the prefs being set at run-time.
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Depends on: 478928
(Assignee)

Comment 6

10 years ago
http://hg.mozilla.org/mozilla-central/rev/6d517e6e35bb
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Comment 7

10 years ago
Created attachment 362883 [details] [diff] [review]
As landed [Checked-in comment 6]
Attachment #353152 - Attachment is obsolete: true
(Assignee)

Comment 8

10 years ago
Looks like on optimized test-enabled builds these tests are not very stable. For now disabling (not backing out).
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 9

10 years ago
Created attachment 362930 [details] [diff] [review]
Disabling tests [Checked-in comment 10]
(Assignee)

Updated

10 years ago
Status: REOPENED → ASSIGNED
(Assignee)

Updated

10 years ago
Attachment #362930 - Attachment description: Disabling tests → Disabling tests [Checked-in comment 10]
(Assignee)

Updated

10 years ago
Depends on: 480713
(Assignee)

Updated

10 years ago
Depends on: 487402
(Assignee)

Updated

10 years ago
Depends on: 487632
(Assignee)

Comment 11

9 years ago
There are followups for all problems caused by this patch. No more need to keep this open.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago9 years ago
Resolution: --- → FIXED
Depends on: 517938
Blocks: 524812
No longer blocks: 524812
Depends on: 734065
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.